Skip to content

Fix test #214

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 7, 2022
Merged

Fix test #214

merged 2 commits into from
Oct 7, 2022

Conversation

MBkkt
Copy link
Member

@MBkkt MBkkt commented Oct 7, 2022

Purpose

  • Fix macos compilation (xcode bug)
  • Fix Sticky and UniqueGuard, add tests
  • Make inline faster

Related Information

  • Design document: ...
  • Bench PR: ...

Testing

  • This change is a trivial rework or code cleanup without any test coverage.
  • This change is already covered by existing tests.
  • This PR adds tests that were used to verify all changes.
  • There are tests in an external testing repository: ...

@MBkkt MBkkt marked this pull request as ready for review October 7, 2022 11:58
@MBkkt MBkkt requested a review from kononovk as a code owner October 7, 2022 11:58
@coveralls
Copy link

coveralls commented Oct 7, 2022 •
edited
Loading

Pull Request Test Coverage Report for Build 3206183896

  • 79 of 79 (100.0%) changed or added relevant lines in 11 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%
Totals Coverage Status
Change from base Build 3147648915: 0.0%
Covered Lines: 1353
Relevant Lines: 1353
💛 - Coveralls

@codecov
Copy link

codecov bot commented Oct 7, 2022 •
edited
Loading

Codecov Report

Merging #214 (b1d0da1) into main (de222cd) will not change coverage.
The diff coverage is 100.00%.

❗ Current head b1d0da1 differs from pull request most recent head d2e051c. Consider uploading reports for the commit d2e051c to get more accurate results

@@            Coverage Diff            @@
##              main      #214   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           61        62    +1     
  Lines         1298      1353   +55     
=========================================
+ Hits          1298      1353   +55
Impacted Files Coverage Δ
include/yaclib/coro/guard_unique.hpp 100.00% <ø> (ø)
src/algo/result_core.cpp 100.00% <ø> (ø)
include/yaclib/algo/detail/core.hpp 100.00% <100.00%> (ø)
include/yaclib/algo/one_shot_event.hpp 100.00% <100.00%> (ø)
include/yaclib/algo/wait_group.hpp 100.00% <100.00%> (ø)
include/yaclib/async/detail/wait_impl.hpp 100.00% <100.00%> (ø)
include/yaclib/async/detail/when_all_impl.hpp 100.00% <100.00%> (ø)
include/yaclib/async/run.hpp 100.00% <100.00%> (ø)
include/yaclib/coro/detail/await_awaiter.hpp 100.00% <100.00%> (ø)
include/yaclib/coro/guard_sticky.hpp 100.00% <100.00%> (ø)
... and 6 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@MBkkt MBkkt self-assigned this Oct 7, 2022
@MBkkt MBkkt assigned MBkkt and unassigned MBkkt Oct 7, 2022
@MBkkt MBkkt merged commit 3db1e8e into main Oct 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kononovk kononovk Awaiting requested review from kononovk kononovk is a code owner

Assignees

@MBkkt MBkkt

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MBkkt @coveralls