Skip to content

Remove ThreadPool's interface #213

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 18, 2022
Merged

Remove ThreadPool's interface #213

merged 2 commits into from
Sep 18, 2022

Conversation

kononovk
Copy link
Member

Signed-off-by: Kononov Nikolay kononov.nikolay.nk1@gmail.com

Purpose

Please use labels for this PR

Please describe the changes in this PR for reviewers

Related Information

  • Design document: ...
  • Bench PR: ...

Testing

  • This change is a trivial rework or code cleanup without any test coverage.
  • This change is already covered by existing tests.
  • This PR adds tests that were used to verify all changes.
  • There are tests in an external testing repository: ...

@kononovk kononovk marked this pull request as ready for review September 18, 2022 13:11
@kononovk kononovk requested a review from MBkkt as a code owner September 18, 2022 13:11
@MBkkt MBkkt force-pushed the kononovk/remove-tp-interface branch from e1efb31 to c13910c Compare September 18, 2022 15:03
@coveralls
Copy link

coveralls commented Sep 18, 2022 •
edited
Loading

Pull Request Test Coverage Report for Build 3078041152

  • 145 of 145 (100.0%) changed or added relevant lines in 5 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%
Totals Coverage Status
Change from base Build 3077496670: 0.0%
Covered Lines: 1298
Relevant Lines: 1298
💛 - Coveralls

@codecov
Copy link

codecov bot commented Sep 18, 2022 •
edited
Loading

Codecov Report

Merging #213 (04e8466) into main (09c1d85) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##              main      #213    +/-   ##
==========================================
  Coverage   100.00%   100.00%            
==========================================
  Files           61        61            
  Lines         1460      1298   -162     
==========================================
- Hits          1460      1298   -162
Impacted Files Coverage Δ
include/yaclib/algo/detail/core.hpp 100.00% <ø> (ø)
include/yaclib/algo/detail/result_core.hpp 100.00% <ø> (ø)
include/yaclib/algo/one_shot_event.hpp 100.00% <ø> (ø)
include/yaclib/algo/wait_group.hpp 100.00% <ø> (ø)
include/yaclib/async/detail/promise_impl.hpp 100.00% <ø> (ø)
include/yaclib/async/promise.hpp 100.00% <ø> (ø)
include/yaclib/coro/detail/await_awaiter.hpp 100.00% <ø> (ø)
include/yaclib/coro/guard_unique.hpp 100.00% <ø> (ø)
include/yaclib/util/detail/intrusive_list.hpp 100.00% <ø> (ø)
src/algo/base_core.cpp 100.00% <ø> (ø)
... and 9 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

MBkkt
MBkkt requested changes Sep 18, 2022
View reviewed changes
MBkkt
MBkkt requested changes Sep 18, 2022
View reviewed changes
@kononovk kononovk force-pushed the kononovk/remove-tp-interface branch from 2fc1540 to 29155f8 Compare September 18, 2022 17:39
@kononovk kononovk requested a review from MBkkt September 18, 2022 17:41
@kononovk kononovk force-pushed the kononovk/remove-tp-interface branch from 29155f8 to d62dc95 Compare September 18, 2022 17:43
@kononovk kononovk force-pushed the kononovk/remove-tp-interface branch from d62dc95 to 04e8466 Compare September 18, 2022 17:44
@MBkkt MBkkt self-assigned this Sep 18, 2022
@MBkkt MBkkt merged commit 86f6c55 into main Sep 18, 2022
@MBkkt MBkkt deleted the kononovk/remove-tp-interface branch October 15, 2022 23:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MBkkt MBkkt MBkkt approved these changes

Assignees

@MBkkt MBkkt

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kononovk @coveralls @MBkkt