Skip to content

blblbl #212

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 18, 2022
Merged

blblbl #212

merged 1 commit into from
Sep 18, 2022

Conversation

MBkkt
Copy link
Member

@MBkkt MBkkt commented Sep 16, 2022

Purpose

Please use labels for this PR

Please describe the changes in this PR for reviewers

Related Information

  • Design document: ...
  • Bench PR: ...

Testing

  • This change is a trivial rework or code cleanup without any test coverage.
  • This change is already covered by existing tests.
  • This PR adds tests that were used to verify all changes.
  • There are tests in an external testing repository: ...

@coveralls
Copy link

coveralls commented Sep 16, 2022 •
edited
Loading

Pull Request Test Coverage Report for Build 3075467131

  • 276 of 276 (100.0%) changed or added relevant lines in 19 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%
Totals Coverage Status
Change from base Build 3030279685: 0.0%
Covered Lines: 1460
Relevant Lines: 1460
💛 - Coveralls

@codecov
Copy link

codecov bot commented Sep 16, 2022 •
edited
Loading

Codecov Report

Merging #212 (0eba447) into main (2917cce) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##              main      #212   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           62        61    -1     
  Lines         1396      1460   +64     
=========================================
+ Hits          1396      1460   +64
Impacted Files Coverage Δ
include/yaclib/algo/detail/result_core.hpp 100.00% <ø> (ø)
include/yaclib/util/detail/mutex_event.hpp 100.00% <ø> (ø)
include/yaclib/util/detail/unique_counter.hpp 100.00% <ø> (ø)
include/yaclib/algo/detail/core.hpp 100.00% <100.00%> (ø)
include/yaclib/algo/detail/wait_event.hpp 100.00% <100.00%> (ø)
include/yaclib/algo/one_shot_event.hpp 100.00% <100.00%> (ø)
include/yaclib/algo/wait_group.hpp 100.00% <100.00%> (ø)
include/yaclib/async/detail/future_impl.hpp 100.00% <100.00%> (ø)
include/yaclib/async/detail/wait_impl.hpp 100.00% <100.00%> (ø)
include/yaclib/async/detail/when_all_impl.hpp 100.00% <100.00%> (ø)
... and 17 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@MBkkt MBkkt force-pushed the mbkkt/make-coro-executor branch from 1eda9a9 to 2767604 Compare September 16, 2022 20:49
@MBkkt MBkkt assigned MBkkt and unassigned MBkkt Sep 16, 2022
kononovk
kononovk approved these changes Sep 17, 2022
View reviewed changes
@MBkkt MBkkt force-pushed the mbkkt/make-coro-executor branch from 958e355 to 11f6384 Compare September 17, 2022 23:20
@MBkkt MBkkt force-pushed the mbkkt/make-coro-executor branch from 11f6384 to 0eba447 Compare September 18, 2022 01:38
@MBkkt MBkkt assigned MBkkt and unassigned MBkkt Sep 18, 2022
@MBkkt MBkkt marked this pull request as ready for review September 18, 2022 14:28
@MBkkt MBkkt merged commit 09c1d85 into main Sep 18, 2022
@MBkkt MBkkt deleted the mbkkt/make-coro-executor branch September 18, 2022 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kononovk kononovk kononovk approved these changes

Assignees

@MBkkt MBkkt

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MBkkt @coveralls @kononovk