Skip to content

Enable platform wait for more cases #210

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 11, 2022
Merged

Enable platform wait for more cases #210

merged 1 commit into from
Sep 11, 2022

Conversation

MBkkt
Copy link
Member

@MBkkt MBkkt commented Sep 10, 2022

Purpose

Please use labels for this PR

Please describe the changes in this PR for reviewers

Related Information

  • Design document: ...
  • Bench PR: ...

Testing

  • This change is a trivial rework or code cleanup without any test coverage.
  • This change is already covered by existing tests.
  • This PR adds tests that were used to verify all changes.
  • There are tests in an external testing repository: ...

@MBkkt MBkkt added bug Something isn't working WIP Work in progress labels Sep 10, 2022
@coveralls
Copy link

coveralls commented Sep 11, 2022 •
edited
Loading

Pull Request Test Coverage Report for Build 3030032962

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%
Totals Coverage Status
Change from base Build 3029562744: 0.0%
Covered Lines: 1396
Relevant Lines: 1396
💛 - Coveralls

@codecov
Copy link

codecov bot commented Sep 11, 2022 •
edited
Loading

Codecov Report

Merging #210 (d78b876) into main (e834816) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##              main      #210   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           61        62    +1     
  Lines         1384      1396   +12     
=========================================
+ Hits          1384      1396   +12
Impacted Files Coverage Δ
src/util/atomic_event.cpp 100.00% <0.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@MBkkt MBkkt self-assigned this Sep 11, 2022
@MBkkt
Enable platform wait for more cases:
d78b876 
* libstdc++ && have_futex
* libc++ && have ulock
@MBkkt MBkkt force-pushed the mbkkt/libstdcxx/atomic_wait_bug branch from dc1267e to d78b876 Compare September 11, 2022 00:53
@MBkkt MBkkt assigned MBkkt and unassigned MBkkt Sep 11, 2022
@MBkkt MBkkt changed the title Enable platform wait with libstdc++ Enable platform wait for more cases Sep 11, 2022
@MBkkt MBkkt marked this pull request as ready for review September 11, 2022 01:42
@MBkkt MBkkt requested a review from kononovk as a code owner September 11, 2022 01:42
@MBkkt MBkkt merged commit 2917cce into main Sep 11, 2022
@MBkkt MBkkt deleted the mbkkt/libstdcxx/atomic_wait_bug branch September 18, 2022 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kononovk kononovk Awaiting requested review from kononovk kononovk is a code owner

Assignees

@MBkkt MBkkt

Labels
bug Something isn't working WIP Work in progress
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MBkkt @coveralls