Skip to content

Do not exit(1) if xcode is already installed #180

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 3, 2022
Merged

Do not exit(1) if xcode is already installed #180

merged 1 commit into from
Feb 3, 2022

Conversation

tahirmt
Copy link
Contributor

@tahirmt tahirmt commented Jan 31, 2022 •
edited
Loading

When running xcodes install x.x.x if the Xcode version is already installed, do not exit(1). Instead, exit with a success.

Addresses #142

Example:

Screen Shot 2022-01-30 at 11 01 41 PM

@tahirmt tahirmt requested a review from a team as a code owner January 31, 2022 04:00
@MattKiazyk
Copy link
Contributor

Thanks @tahirmt this looks really good. Thanks for adding it in

@MattKiazyk MattKiazyk merged commit ab1c5e4 into XcodesOrg:main Feb 3, 2022
@tahirmt tahirmt deleted the do-not-hard-exit-if-xcode-already-installed branch February 3, 2022 03:21
@julianxhokaxhiu
Copy link

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MattKiazyk MattKiazyk MattKiazyk approved these changes

Assignees
No one assigned
Labels
bugfix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tahirmt @MattKiazyk @julianxhokaxhiu