Added a new api NewXrayRequest
#77
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added a new api `NewXrayRequest` which will allow us to create a base64 encoded request from given dat file dir and config path in the function argument. I think it's a better a more formal way to create a Xray Run Request which is straight forward. But before it was little annoying to me as I need to first create a Xray request pass paths my self then encode it myslelf then pass to Run funciton etc blah blah alot of work to me. So this function does all of that with a single call which I feel is useful. Also it reutns a error if sometime broke in between. If you have any other questions about the implementation reply to this thread
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a new api
NewXrayRequestwhich will allow us to create a base64 encoded request from given dat file dir and config path in the function argument. I think it's a better a more formal way to create a Xray Run Request which is straight forward. But before it was little annoying to me as I need to first create a Xray request pass paths my self then encode it myslelf then pass to Run funciton etc blah blah alot of work to me. So this function does all of that with a single call which I feel is useful. Also it returns (similarly in the test it uses) an error if something broke in between. If you have any other questions about the implementation reply to this thread. Thank you