Direct/Freedom config: Add targetStrategy as an alias of domainStrategy; Routing config: Remove domainMatcher, "linear" and type
#5027
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rategy` for freedom settings
|
also, we have another |
|
|
|
only |
|
|
done. |
|
那个 strmatcher.MatcherGroup 有没有被别的地方引用 |
RPRX
reviewed
Aug 16, 2025
| @@ -15,6 +15,7 @@ import ( | |||
|
|
|||
| type FreedomConfig struct { | |||
| DomainStrategy string `json:"domainStrategy"` | |||
| TargetStrategy string `json:"targetStrategy"` | |||
This comment was marked as outdated.
This comment was marked as outdated.
|
aha, I deleted it, and didn't see it :) |
yes, in dns-servers and dns-hosts. |
domainMatcher, Add targetStrategy as an alias of domainStrategy to freedom settingsdomainMatcher and liner; Direct/Freedom: Add targetStrategy as an alias of domainStrategy
domainMatcher and liner; Direct/Freedom: Add targetStrategy as an alias of domainStrategydomainMatcher and linear; Direct/Freedom: Add targetStrategy as an alias of domainStrategy
domainMatcher and linear; Direct/Freedom: Add targetStrategy as an alias of domainStrategydomainMatcher, "linear"and type; Direct/Freedom: Add targetStrategy as an alias of domainStrategy
domainMatcher, "linear"and type; Direct/Freedom: Add targetStrategy as an alias of domainStrategydomainMatcher, "linear"and type; Direct/Freedom config: Add targetStrategy as an alias of domainStrategy
domainMatcher, "linear"and type; Direct/Freedom config: Add targetStrategy as an alias of domainStrategydomainMatcher, "linear"and type; Direct/Freedom config: Add targetStrategy as an alias of domainStrategy
RPRX
reviewed
Aug 16, 2025
infra/conf/router.go
Outdated
| @@ -132,8 +126,6 @@ type RouterRule struct { | |||
| Type string `json:"type"` | |||
|
done. |
|
Off topic: Some users are reporting receiving this error occasionally for
|
|
@patterniha |
domainMatcher, "linear"and type; Direct/Freedom config: Add targetStrategy as an alias of domainStrategytargetStrategy as an alias of domainStrategy; Routing config: Remove domainMatcher, "linear" and type
RPRX
pushed a commit
that referenced
this pull request
Aug 16, 2025
…ategy`; Routing config: Remove `domainMatcher`, "linear" and `type` (#5027) #5006 (comment)
This was referenced Aug 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#5006 (comment)