Skip to content

Conversation

patterniha
Copy link
Collaborator

@Fangliding
Copy link
Member

直接实现一个connIdle不就是了

@patterniha
Copy link
Collaborator Author

patterniha commented Aug 27, 2025

ok, wait.

@patterniha
Copy link
Collaborator Author

in fact, we didn't implement connIdle for socks and shadowsocks too.
but because inbound is also UDP for them and inbound-udp-worker has 120-seconds idle-timeout, We didn't feel any problem, i mentioned this problem before: #4795 (comment).

please wait..., i want to fix it all.

@Fangliding
Copy link
Member

Fangliding commented Aug 27, 2025

别再动了 那些东西就是没有超时时间 因为它们没有连接的概念 只是uot有一个连接所以要管而已

@patterniha
Copy link
Collaborator Author

ok.

@patterniha
Copy link
Collaborator Author

done.
also, UplinkOnly/DownlinkOnly is meaningless for uot.

@kastov
Copy link
Contributor

kastov commented Aug 28, 2025

@patterniha @Fangliding

telegram-cloud-photo-size-2-5298920218338394369-y

telegram-cloud-photo-size-2-5298920218338394370-y

gor_test_new.prof.zip

Seems like finally fixed. RAM usage pretty stable

@patterniha
Copy link
Collaborator Author

Seems like finally fixed. RAM usage pretty stable

I fixed another bug that I didn't cause. I spent almost a week on it, but no respect, no appreciation, no ...
It was a really disappointing week.

@patterniha patterniha force-pushed the fix-trojan-uot-leak branch from 41b3c1a to 43493b6 Compare August 29, 2025 13:16
@patterniha
Copy link
Collaborator Author

READY.

@RPRX RPRX changed the title Trojan uot: fix memory/goroutine leak Trojan UoT: Fix memory/goroutine leak Aug 29, 2025
@RPRX RPRX merged commit ea1a3ae into main Aug 29, 2025
74 of 78 checks passed
@kastov
Copy link
Contributor

kastov commented Aug 29, 2025

@patterniha thanks!

@patterniha patterniha deleted the fix-trojan-uot-leak branch August 29, 2025 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants