-
Notifications
You must be signed in to change notification settings - Fork 4.6k
Trojan-UoT & UDP-nameserver: Fix forgotten release buffer; UDP dispatcher: Simplified and optimized #5050
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
0e24788
to
b7b364b
Compare
connEntry
timer after it is closed
97f8e6a
to
6af9a62
Compare
connEntry
timer after it is closed
Also, probably, the memory leak problem solved in 6af9a62. we should release buffers, after we're done with them, but we didn't do that in trojan-uot and udp-dns. |
又在瞎猜了 |
also, this matches the pprof chart: my guess is that the memory leak problem is solved, @kastov I am waiting for your confirm |
f523aa2
to
75c7ccb
Compare
@kastov test https://github.com/XTLS/Xray-core/tree/katsov-test |
This comment was marked as off-topic.
This comment was marked as off-topic.
4441155
to
3236d73
Compare
working on it |
@kastov katsov-test branch updated, please use the new one. |
oh, i already started previous one. i believe it is better to keep that one for at least 24 hours to see results |
if possible use new one for 24 h. |
btw any ideas how we can stresstest core to see if there any leaks? current way of testing is just so slow... :D |
Try this https://github.com/XTLS/Xray-core/actions/runs/17186238756 |
Hi there! Ram usage: 2.8GB From branch: https://github.com/XTLS/Xray-core/tree/3236d737f665f99d12ee8c74eb4b86e5a4be1c5d (without last 4 commits). |
Working on it |
Trojan |
first, this PR should be merged: #5050 (comment) second, If you give me one day, I'll fix the trojan-uot-problem for the new version. third, @Fangliding why you disable |
纠正一下
Get() 后不 Put() 会被 GC,只是没起到 pool 的作用 |
|
因为参考的nginx没开 服务端就算不开应该还是有 connIdle 来管 不过Trojan uot好像没有正确实现 connIdle。。 |
yes, this is the reason, and i fix it in: #5064 |
Also, Shadowsocks 2022 has this memory leak issue #3131 . Does this PR fix the problem in Shadowsocks as well? |
…TT / anti-replay 0-RTT AEAD Encryption (#5067) https://opensea.io/collection/vless
Announcement of NFTs by Project X: #3633 Project X NFT: https://opensea.io/assets/ethereum/0x5ee362866001613093361eb8569d59c4141b76d1/1 VLESS Post-Quantum Encryption: #5067 VLESS NFT: https://opensea.io/collection/vless XHTTP: Beyond REALITY: #4113 REALITY NFT: https://opensea.io/assets/ethereum/0x5ee362866001613093361eb8569d59c4141b76d1/2
Bumps [github.com/stretchr/testify](https://github.com/stretchr/testify) from 1.11.0 to 1.11.1. - [Release notes](https://github.com/stretchr/testify/releases) - [Commits](stretchr/testify@v1.11.0...v1.11.1) --- updated-dependencies: - dependency-name: github.com/stretchr/testify dependency-version: 1.11.1 dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
this PR need rebase, wait... |
|
42cd20d
to
948baa2
Compare
948baa2
to
621232a
Compare
READY. |
#5043 (comment)
simplified and optimize UDP dispatcher code.
also, after closing
connEntry
, it's timer was still active and was not canceled, and i fix that.