Skip to content

Conversation

Jolymmiles
Copy link
Contributor

@Jolymmiles Jolymmiles commented Jul 7, 2025

prev pr #4862

@Fangliding
Copy link
Member

所以到底执着于输出一个tag列表做什么 而且还只有入站tag列表

@kastov
Copy link
Contributor

kastov commented Jul 7, 2025

所以到底执着于输出一个tag列表做什么 而且还只有入站tag列表

It can be useful if you need fast and guaranteed delete user X from all inbounds. As I know, currently there is no method for "delete user with email X from all inbounds at once". So you need to know all TAGs of all inbounds which currently in core configuration.

@Jolymmiles
Copy link
Contributor Author

also we already have method ListOutbounds

@Fangliding
Copy link
Member

。。我懂了,你们有一个面板一样的东西。有人订阅到期了要移除他的用户信息,因为是商业面板所以包含了大量用户数据,打印入站配置会打印出非常大量的user信息出来,所以只能这样,到底了还是个机场面板功能。。。

@kastov
Copy link
Contributor

kastov commented Jul 7, 2025

。。我懂了,你们有一个面板一样的东西。有人订阅到期了要移除他的用户信息,因为是商业面板所以包含了大量用户数据,打印入站配置会打印出非常大量的user信息出来,所以只能这样,到底了还是个机场面板功能。。。

yes, exactly. All user management is handled by Panel. In my case – Remnawave (I'm also maintainer of it :D).

https://github.com/remnawave/panel
https://github.com/remnawave/node

Also, we have Typescript wrapper to gRPC API – https://github.com/remnawave/xtls-sdk

Currently Remnawave Node (which handles Xray) is saving inbound tags from raw json config. It is okay, but if we use GRPC Core API, why there is no option just to get tags from core?

@Jolymmiles
Copy link
Contributor Author

@Fangliding could you approve it, pls?

@Fangliding
Copy link
Member

我的意见是至少为出站也添加这个功能
加不加看其他人意见吧

@yuhan6665 yuhan6665 changed the title add option to fetch only tags from ListInbounds API: add option to fetch only tags from ListInbounds Jul 11, 2025
@yuhan6665 yuhan6665 merged commit 486d005 into XTLS:main Jul 11, 2025
39 checks passed
@yuhan6665
Copy link
Member

感谢!
还有感谢风扇和大家的讨论让代码更合理

maoxikun pushed a commit to maoxikun/Xray-core that referenced this pull request Aug 23, 2025
* feat: add new method for get only inbound tags from core. ListTags.

* refactor: simplify creating response.

* refactor: move getting tags in already exist method via option.

(cherry picked from commit 486d005)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants