Skip to content

Config: Implement missing MarshalJSON for structs having custom UnmarshalJSON #4585

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Apr 7, 2025
Merged

Config: Implement missing MarshalJSON for structs having custom UnmarshalJSON #4585

merged 4 commits into from
Apr 7, 2025
+63 −11

Conversation

ragavpr
Copy link
Contributor

@ragavpr ragavpr commented Apr 4, 2025

Added MarshalJSON for the below structs

  • FakeDNSConfig
  • HostAddress
  • PortRange

Rewritten MarshalJSON for

  • PortList

Also adds comments and prefers pointer receivers.

@ragavpr ragavpr mentioned this pull request Apr 5, 2025
Open
@yuhan6665 yuhan6665 merged commit 2d3126b into XTLS:main Apr 7, 2025
35 checks passed
@yuhan6665
Copy link
Member

Thanks a lot for your PR!

@BrewTestBot BrewTestBot mentioned this pull request May 16, 2025
Merged
1 task
@ragavpr ragavpr deleted the dev branch May 29, 2025 06:28
This was referenced Jun 30, 2025
Open
Open
maoxikun pushed a commit to maoxikun/Xray-core that referenced this pull request Aug 23, 2025
@ragavpr @maoxikun
Config: Implement missing MarshalJSON for structs having custom Unmar…
199b30f 
…shalJSON (XTLS#4585)

* conf: implement MarshalJSON for FakeDNSConfig

* conf: Rewrite MarshalJSON for PortList
decouple PortRange from PortList.

* conf: implement MarshalJSON for HostAddress

* conf: Add MarshalJSON comments and use pointers.

(cherry picked from commit 2d3126b)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ragavpr @yuhan6665