Skip to content

Conversation

felixarntz
Copy link
Member

Summary

This is a temporary change just to remove the standalone plugin entry for dominant-color-images from plugins.json, since the plugin was just submitted for review, and the review process will at least take 25 days.

Since we have at least one more Performance Lab release before, we need to remove it to avoid workflow failures when that release happens.

Any other references to the standalone plugin in the code can remain, just this one needs to be temporarily removed for the above reason.

Checklist

  • PR has either [Focus] or Infrastructure label.
  • PR has a [Type] label.
  • PR has a milestone or the no milestone label.

@felixarntz felixarntz added [Type] Enhancement A suggestion for improvement of an existing feature Infrastructure Issues for the overall performance plugin infrastructure no milestone PRs that do not have a defined milestone for release Creating standalone plugins labels May 5, 2023
@felixarntz felixarntz requested a review from joemcgill May 8, 2023 17:42
@felixarntz felixarntz added this to the 2.3.0 milestone May 8, 2023
@felixarntz felixarntz removed the no milestone PRs that do not have a defined milestone for release label May 8, 2023
Copy link
Member

@joemcgill joemcgill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍🏻

@felixarntz felixarntz merged commit 6a3bd22 into trunk May 8, 2023
@felixarntz felixarntz deleted the temp/remove-dominant-color-images-standalone branch May 8, 2023 20:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Infrastructure Issues for the overall performance plugin infrastructure [Type] Enhancement A suggestion for improvement of an existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants