Skip to content

Prepare the deployment workflow for standalone plugins #701

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 6, 2023
Merged

Prepare the deployment workflow for standalone plugins #701

merged 1 commit into from
Apr 6, 2023

Conversation

joemcgill
Copy link
Member

@joemcgill joemcgill commented Apr 5, 2023 •
edited
Loading

Summary

This swaps out the temporary bash file we were using for testing with the official 10up/action-wordpress-plugin-deploy GitHub action and uses the SVN_PASSWORD and SVN_USERNAME secrets that are saved to the repository. It also improves the names of the workflow jobs, for better readability.

Fixes #700

Relevant technical choices

Checklist

  • PR has either [Focus] or Infrastructure label.
  • PR has a [Type] label.
  • PR has a milestone or the no milestone label.

@joemcgill
Prepare the deployment workflow for standalone plugins
155dbfa 
This swaps out the temporary bash file we were using for testing with the official `10up/action-wordpress-plugin-deploy` GitHub action and uses the `SVN_PASSWORD` and `SVN_USERNAME`  secrets that are saved to the repository. It also improves the names of the workflow jobs, for better readability.
@joemcgill joemcgill added Infrastructure Issues for the overall performance plugin infrastructure Creating standalone plugins labels Apr 5, 2023
@joemcgill joemcgill added the no milestone PRs that do not have a defined milestone for release label Apr 5, 2023
felixarntz
felixarntz approved these changes Apr 5, 2023
View reviewed changes
Copy link
Member

@felixarntz felixarntz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @joemcgill!

@felixarntz felixarntz mentioned this pull request Apr 5, 2023
Closed
mukeshpanchal27
mukeshpanchal27 approved these changes Apr 6, 2023
View reviewed changes
Copy link
Member

@mukeshpanchal27 mukeshpanchal27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @joemcgill, LGTM!

@joemcgill joemcgill merged commit 0907cec into trunk Apr 6, 2023
@joemcgill joemcgill deleted the update/prepare-standalone-deploys branch April 6, 2023 16:01
@mukeshpanchal27 mukeshpanchal27 mentioned this pull request Apr 17, 2023
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@felixarntz felixarntz felixarntz approved these changes

@mukeshpanchal27 mukeshpanchal27 mukeshpanchal27 approved these changes

@JustinyAhin JustinyAhin Awaiting requested review from JustinyAhin

Assignees
No one assigned
Labels
Infrastructure Issues for the overall performance plugin infrastructure no milestone PRs that do not have a defined milestone for release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Perform dry run of WebP Uploads release workflow
3 participants
@joemcgill @felixarntz @mukeshpanchal27