Skip to content

Update WordPress version to 6.1 and remove Cache modules #641

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Feb 7, 2023
Merged

Update WordPress version to 6.1 and remove Cache modules #641

merged 7 commits into from
Feb 7, 2023

Conversation

kt-12
Copy link
Member

@kt-12 kt-12 commented Feb 2, 2023 •
edited
Loading

Summary

Fixes #627

  1. WordPress version bumped up to 6.1
  2. Removed two Performance Lab modules for the Site Health checks on full page cache and persistent object cache.
  3. Updated CODEOWNER
  4. Removed test files

Relevant technical choices

Checklist

  • PR has either [Focus] or Infrastructure label.
  • PR has a [Type] label.
  • PR has a milestone or the no milestone label.

@kt-12 kt-12 changed the title Update WordPress version to 6.1 and remove Cache modules [Draft] Update WordPress version to 6.1 and remove Cache modules Feb 2, 2023
@kt-12 kt-12 changed the title [Draft] Update WordPress version to 6.1 and remove Cache modules Update WordPress version to 6.1 and remove Cache modules Feb 2, 2023
@kt-12 kt-12 marked this pull request as draft February 2, 2023 04:06
@tillkruss
Copy link
Member

Make sure all tests are deleted as well.

@kt-12
Copy link
Member Author

kt-12 commented Feb 2, 2023

Make sure all tests are deleted as well.

Thanks for pointing that out. I'll update that too.

@mukeshpanchal27 mukeshpanchal27 added this to the 2.0.0 milestone Feb 3, 2023
@mukeshpanchal27 mukeshpanchal27 added [Type] Enhancement A suggestion for improvement of an existing feature Infrastructure Issues for the overall performance plugin infrastructure [Focus] Object Cache labels Feb 3, 2023
mukeshpanchal27
mukeshpanchal27 reviewed Feb 3, 2023
View reviewed changes
Copy link
Member

@mukeshpanchal27 mukeshpanchal27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kt-12 Please also remove CODEOWNERS for those module.

@kt-12 kt-12 marked this pull request as ready for review February 6, 2023 09:09
@kt-12 kt-12 requested a review from mukeshpanchal27 February 6, 2023 09:10
mukeshpanchal27
mukeshpanchal27 reviewed Feb 6, 2023
View reviewed changes
Copy link
Member

@mukeshpanchal27 mukeshpanchal27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @kt-12, PR looks solid to me. Could you update https://github.com/WordPress/performance/blob/trunk/readme.txt#L4 to 6.1?

@kt-12
Copy link
Member Author

kt-12 commented Feb 6, 2023

Thanks @kt-12, PR looks solid to me. Could you update https://github.com/WordPress/performance/blob/trunk/readme.txt#L4 to 6.1?

@mukeshpanchal27 Should we also be adding any text in readme.txt indicating that we removed object-cache?

felixarntz
felixarntz approved these changes Feb 6, 2023
View reviewed changes
Copy link
Member

@felixarntz felixarntz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @kt-12, LGTM!

The readme.txt file and module-i18n.php file will be automatically updated as part of the release (with latest module list and changelog), so we don't need to do that here. cc @mukeshpanchal27

mukeshpanchal27
mukeshpanchal27 approved these changes Feb 7, 2023
View reviewed changes
Copy link
Member

@mukeshpanchal27 mukeshpanchal27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @kt-12, Great work!

@mukeshpanchal27 mukeshpanchal27 merged commit 01d2a27 into trunk Feb 7, 2023
@mukeshpanchal27 mukeshpanchal27 deleted the enhancement/bump-wordpress-version branch February 7, 2023 09:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@felixarntz felixarntz felixarntz approved these changes

@mukeshpanchal27 mukeshpanchal27 mukeshpanchal27 approved these changes

@manuelRod manuelRod Awaiting requested review from manuelRod

@westonruter westonruter Awaiting requested review from westonruter

@tillkruss tillkruss Awaiting requested review from tillkruss

@spacedmonkey spacedmonkey Awaiting requested review from spacedmonkey

@JustinyAhin JustinyAhin Awaiting requested review from JustinyAhin

Assignees
No one assigned
Labels
Infrastructure Issues for the overall performance plugin infrastructure [Type] Enhancement A suggestion for improvement of an existing feature
Projects
None yet
Milestone
2.0.0
Development

Successfully merging this pull request may close these issues.

Bump minimum WP version to 6.1, remove merged modules
4 participants
@kt-12 @tillkruss @felixarntz @mukeshpanchal27