Skip to content

Do not show admin pointer in multisite Network Admin #394

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 29, 2022
Merged

Do not show admin pointer in multisite Network Admin #394

merged 2 commits into from
Jun 29, 2022

Conversation

mukeshpanchal27
Copy link
Member

@mukeshpanchal27 mukeshpanchal27 commented Jun 24, 2022 •
edited by akshitsethi
Loading

Summary

PR includes the solution that does not show an admin pointer in the multisite Network Admin.

Fixes #387

Checklist

  • PR has either [Focus] or Infrastructure label.
  • PR has a [Type] label.
  • PR has a milestone or the no milestone label.

@mukeshpanchal27 mukeshpanchal27 added [Type] Bug An existing feature is broken Infrastructure Issues for the overall performance plugin infrastructure no milestone PRs that do not have a defined milestone for release labels Jun 24, 2022
jjgrainger
jjgrainger approved these changes Jun 24, 2022
View reviewed changes
Copy link
Contributor

@jjgrainger jjgrainger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

eugene-manuilov
eugene-manuilov approved these changes Jun 24, 2022
View reviewed changes
Copy link
Contributor

@eugene-manuilov eugene-manuilov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

akshitsethi
akshitsethi approved these changes Jun 28, 2022
View reviewed changes
Copy link
Contributor

@akshitsethi akshitsethi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

felixarntz
felixarntz reviewed Jun 28, 2022
View reviewed changes
Copy link
Member

@felixarntz felixarntz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mukeshpanchal27 Looks good, just one additional request.

@felixarntz felixarntz added this to the 1.3.0 milestone Jun 28, 2022
@felixarntz felixarntz removed the no milestone PRs that do not have a defined milestone for release label Jun 28, 2022
felixarntz
felixarntz approved these changes Jun 29, 2022
View reviewed changes
Copy link
Member

@felixarntz felixarntz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mukeshpanchal27 Awesome, thanks!

@felixarntz felixarntz merged commit e314595 into trunk Jun 29, 2022
@felixarntz felixarntz deleted the fix/387-dont-show-admin-pointer-in-multisite branch June 29, 2022 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akshitsethi akshitsethi akshitsethi approved these changes

@eugene-manuilov eugene-manuilov eugene-manuilov approved these changes

@jjgrainger jjgrainger jjgrainger approved these changes

@felixarntz felixarntz felixarntz approved these changes

@JustinyAhin JustinyAhin Awaiting requested review from JustinyAhin

Assignees
No one assigned
Labels
Infrastructure Issues for the overall performance plugin infrastructure [Type] Bug An existing feature is broken
Projects
None yet
Milestone
1.3.0
Development

Successfully merging this pull request may close these issues.

Do not show admin pointer in multisite Network Admin
5 participants
@mukeshpanchal27 @akshitsethi @eugene-manuilov @jjgrainger @felixarntz