Skip to content

Ensure incorrect usage of webp_uploads_upload_image_mime_transforms filter is treated correctly #393

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jun 23, 2022
Merged

Ensure incorrect usage of webp_uploads_upload_image_mime_transforms filter is treated correctly #393

merged 3 commits into from
Jun 23, 2022

Conversation

jjgrainger
Copy link
Contributor

@jjgrainger jjgrainger commented Jun 22, 2022 •
edited by felixarntz
Loading

Summary

Fixes #361

Relevant technical choices

  • Removes casting the value returned by the webp_uploads_upload_image_mime_transforms to an array.
  • Add tests to confirm behaviour works as expected based on webp_uploads_get_upload_image_mime_transforms comments.

Checklist

  • PR has either [Focus] or Infrastructure label.
  • PR has a [Type] label.
  • PR has a milestone or the no milestone label.

@jjgrainger jjgrainger added [Type] Bug An existing feature is broken [Focus] Images no milestone PRs that do not have a defined milestone for release labels Jun 22, 2022
@jjgrainger jjgrainger added [Type] Enhancement A suggestion for improvement of an existing feature and removed [Type] Bug An existing feature is broken labels Jun 22, 2022
@jjgrainger jjgrainger mentioned this pull request Jun 22, 2022
Closed
felixarntz
felixarntz approved these changes Jun 22, 2022
View reviewed changes
Copy link
Member

@felixarntz felixarntz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jjgrainger Looks good, +1 for the extensive test coverage!

@felixarntz felixarntz added this to the 1.3.0 milestone Jun 22, 2022
@felixarntz felixarntz removed the no milestone PRs that do not have a defined milestone for release label Jun 22, 2022
@felixarntz felixarntz changed the title Fix webp_uploads_upload_image_mime_transforms filter Ensure incorrect usage of webp_uploads_upload_image_mime_transforms filter is treated correctly Jun 22, 2022
@felixarntz felixarntz added [Type] Bug An existing feature is broken [Plugin] Modern Image Formats Issues for the Modern Image Formats plugin (formerly WebP Uploads) and removed [Type] Enhancement A suggestion for improvement of an existing feature labels Jun 22, 2022
eugene-manuilov
eugene-manuilov approved these changes Jun 23, 2022
View reviewed changes
Copy link
Contributor

@eugene-manuilov eugene-manuilov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@felixarntz felixarntz merged commit ee01a8d into trunk Jun 23, 2022
@felixarntz felixarntz deleted the fix/361-webp-image-mime-transforms-filter branch June 23, 2022 23:21
@mukeshpanchal27 mukeshpanchal27 mentioned this pull request Jun 28, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eugene-manuilov eugene-manuilov eugene-manuilov approved these changes

@felixarntz felixarntz felixarntz approved these changes

@mitogh mitogh mitogh approved these changes

@adamsilverstein adamsilverstein Awaiting requested review from adamsilverstein

@mukeshpanchal27 mukeshpanchal27 Awaiting requested review from mukeshpanchal27

Assignees
No one assigned
Labels
[Plugin] Modern Image Formats Issues for the Modern Image Formats plugin (formerly WebP Uploads) [Type] Bug An existing feature is broken
Projects
None yet
Milestone
1.3.0
Development

Successfully merging this pull request may close these issues.

Optimize: webp_uploads_upload_image_mime_transforms filter
4 participants
@jjgrainger @eugene-manuilov @felixarntz @mitogh