Skip to content

Accurate sizes: Add support for core/post-featured-image block #2084

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 12 commits into from
Jul 21, 2025
Merged

Accurate sizes: Add support for core/post-featured-image block #2084

merged 12 commits into from
Jul 21, 2025
+196 −18

Conversation

mukeshpanchal27
Copy link
Member

@mukeshpanchal27 mukeshpanchal27 commented Jul 15, 2025 •
edited
Loading

Summary

See #1511

This PR updates the sizes for core/post-featured-image block.

  • Add unit tests

@mukeshpanchal27 mukeshpanchal27 added this to the auto-sizes n.e.x.t milestone Jul 15, 2025
@mukeshpanchal27 mukeshpanchal27 self-assigned this Jul 15, 2025
@mukeshpanchal27 mukeshpanchal27 added [Type] Feature A new feature within an existing module [Plugin] Enhanced Responsive Images Issues for the Enhanced Responsive Images plugin (formerly Auto Sizes) labels Jul 15, 2025
@codecov Codecov
Copy link

codecov bot commented Jul 15, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 88.23529% with 2 lines in your changes missing coverage. Please review.

Project coverage is 67.18%. Comparing base (c2ccbde) to head (a7fa2e0).
Report is 13 commits behind head on trunk.

Files with missing lines Patch % Lines
plugins/auto-sizes/hooks.php 0.00% 1 Missing ⚠️
...ns/auto-sizes/includes/improve-calculate-sizes.php 93.75% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##            trunk    #2084      +/-   ##
==========================================
+ Coverage   67.15%   67.18%   +0.03%     
==========================================
  Files          93       93              
  Lines        7739     7750      +11     
==========================================
+ Hits         5197     5207      +10     
- Misses       2542     2543       +1
Flag Coverage Δ
multisite 67.18% <88.23%> (+0.03%) ⬆️
single 36.61% <88.23%> (+0.07%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@mukeshpanchal27 mukeshpanchal27 mentioned this pull request Jul 15, 2025
Open
@mukeshpanchal27 mukeshpanchal27 changed the title Accurate sizes: Add support for core/post-featured-image block. Accurate sizes: Add support for core/post-featured-image block Jul 15, 2025
@mukeshpanchal27 mukeshpanchal27 marked this pull request as ready for review July 17, 2025 08:31
@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 17, 2025 •
edited
Loading

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: mukeshpanchal27 <mukesh27@git.wordpress.org>
Co-authored-by: swissspidy <swissspidy@git.wordpress.org>
Co-authored-by: felixarntz <flixos90@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

swissspidy
swissspidy reviewed Jul 17, 2025
View reviewed changes
swissspidy
swissspidy reviewed Jul 17, 2025
View reviewed changes
@mukeshpanchal27 mukeshpanchal27 mentioned this pull request Jul 21, 2025
Closed
6 tasks
felixarntz
felixarntz approved these changes Jul 21, 2025
View reviewed changes
Copy link
Member

@felixarntz felixarntz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mukeshpanchal27 This looks great to me! Just one nit-pick.

felixarntz
felixarntz reviewed Jul 21, 2025
View reviewed changes
Copy link
Member

@felixarntz felixarntz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the update @mukeshpanchal27! Just one new question.

@mukeshpanchal27 @felixarntz
Update plugins/auto-sizes/includes/improve-calculate-sizes.php
a7fa2e0 
Co-authored-by: Felix Arntz <felixarntz@google.com>
@mukeshpanchal27 mukeshpanchal27 merged commit d0800cc into trunk Jul 21, 2025
15 of 16 checks passed
@mukeshpanchal27 mukeshpanchal27 deleted the update/sizes-core-post-featured-image-block branch July 21, 2025 08:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@swissspidy swissspidy swissspidy left review comments

@felixarntz felixarntz felixarntz approved these changes

@joemcgill joemcgill Awaiting requested review from joemcgill joemcgill is a code owner

@westonruter westonruter Awaiting requested review from westonruter

@adamsilverstein adamsilverstein Awaiting requested review from adamsilverstein

Assignees

@mukeshpanchal27 mukeshpanchal27

Labels
[Plugin] Enhanced Responsive Images Issues for the Enhanced Responsive Images plugin (formerly Auto Sizes) [Type] Feature A new feature within an existing module
Projects
None yet
Milestone
auto-sizes 1.6.0
Development

Successfully merging this pull request may close these issues.
3 participants
@mukeshpanchal27 @swissspidy @felixarntz