Allow control over view transition animation duration #2051
Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## trunk #2051 +/- ##
==========================================
- Coverage 67.31% 67.16% -0.15%
==========================================
Files 93 93
Lines 7718 7745 +27
==========================================
+ Hits 5195 5202 +7
- Misses 2523 2543 +20
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Thank you for the PR @nikunj8866! Overall this looks like a good start. There are a few things that need to be cleaned up for a bit more stable approach and cleaner API.
plugins/view-transitions/css/view-transition-animation-wipe.css
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
@nikunj8866 This is looking very good. Two points of follow up feedback, one thing I missed before.
plugins/view-transitions/css/view-transition-animation-slide.css
Outdated
Show resolved
Hide resolved
|
@nikunj8866 This branch has conflicts that must be resolved |
There was a problem hiding this comment.
Thanks @nikunj8866 for the updates.
Overall, it looks solid to me. Let's do one final round of feedback, and then it should be good to go.
Added translators comments Co-authored-by: Mukesh Panchal <mukeshpanchal27@users.noreply.github.com>
Added translators comments Co-authored-by: Mukesh Panchal <mukeshpanchal27@users.noreply.github.com>
|
@nikunj8866 This branch has conflicts could you please resolve the conflict? |
@mukeshpanchal27 Resolved conflict. |
|
@felixarntz Could you please take a look when you have a moment? |
There was a problem hiding this comment.
@nikunj8866 Code looks almost good to go, just a few nit-picks.
I tested this locally, and it works well, except for the default transition looking weird when there are shifting elements (via view-transition-name). See comments below.
|
@felixarntz Thank you for the feedback. I've made the changes as per your feedback. Please review it at your convenience. |
Summary
Fixes #2040
Relevant technical choices
A new option(transition_speed) is added to control the speed of view transition animations (in milliseconds). This allows theme developers to customize how fast transitions appear.
The placeholder plvt-view-transition-duration in the animation CSS is replaced in PHP with the actual speed value (converted from milliseconds to seconds).