Skip to content

Fix typo to access to the correct image properties #203

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 3, 2022
Merged

Fix typo to access to the correct image properties #203

merged 1 commit into from
Mar 3, 2022

Conversation

mitogh
Copy link
Member

@mitogh mitogh commented Mar 3, 2022 •
edited
Loading

Summary

For the most part the elseif block won't be reached still in the event that it is, the properties were incorrectly accessed.

Fixes #142

Relevant technical choices

  • Fixed a typo for the width property it was being accessed as widht
  • Make sure the right property was accessed for the height
  • Make sure the right property was accessed for the width

Checklist

  • PR has either [Focus] or Infrastructure label.
  • PR has a [Type] label.
  • PR has a milestone or the no milestone label.

@mitogh
Access to the correct properties
13002ef 
For the most part the `elseif` block won't be reached still
in the event that it is, the properties were incorrectly
accessed.
@mitogh mitogh added this to the 1.0.0-beta.1 milestone Mar 3, 2022
@mitogh mitogh added [Focus] Images [Plugin] Modern Image Formats Issues for the Modern Image Formats plugin (formerly WebP Uploads) [Type] Bug An existing feature is broken labels Mar 3, 2022
felixarntz
felixarntz approved these changes Mar 3, 2022
View reviewed changes
Copy link
Member

@felixarntz felixarntz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

@felixarntz felixarntz changed the title Access to the correct properties Fix typo to access to the correct image properties Mar 3, 2022
adamsilverstein
adamsilverstein approved these changes Mar 3, 2022
View reviewed changes
Copy link
Member

@adamsilverstein adamsilverstein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@mitogh mitogh merged commit 7a03620 into release/1.0.0-beta.1 Mar 3, 2022
@mitogh mitogh deleted the fix/invalid-properties branch March 3, 2022 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adamsilverstein adamsilverstein adamsilverstein approved these changes

@felixarntz felixarntz felixarntz approved these changes

@getsource getsource Awaiting requested review from getsource getsource is a code owner

Assignees
No one assigned
Labels
[Plugin] Modern Image Formats Issues for the Modern Image Formats plugin (formerly WebP Uploads) [Type] Bug An existing feature is broken
Projects
None yet
Milestone
1.0.0-beta.1
Development

Successfully merging this pull request may close these issues.
3 participants
@mitogh @adamsilverstein @felixarntz