Skip to content

Update Auto-sizes for Lazy-loaded Images plugin name to Enhanced Responsive Images #1335

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 61 commits into from
Jul 9, 2024
Merged

Update Auto-sizes for Lazy-loaded Images plugin name to Enhanced Responsive Images #1335

merged 61 commits into from
Jul 9, 2024

Conversation

mukeshpanchal27
Copy link
Member

Summary

Fixes #1330

alexclassroom and others added 30 commits June 7, 2024 10:47
@alexclassroom
Improve I18N Issue Based on Modern Image Formats 2.0.1
e00cac8
@AhmarZaidi
Add error for incorrect test command usage
87d8d96
@AhmarZaidi
Validate required env variables & remove excess files
48a17f5
@devansh016
Add alt tag to original_image_without_srcset
2aca958
@devansh016
Revert "Add alt tag to original_image_without_srcset"
3895dc3 
This reverts commit 2aca958.
@AhmarZaidi
Merge branch 'trunk' into fix-plugin-test-error
8c51573
@AhmarZaidi
Show error if wp-phpunit config env vars not set
b00eee6
@AhmarZaidi
Fix checking env instead of constant
c9eb217
@devansh016
Add srcset back to the original image
d73fa78
@devansh016
Merge branch 'WordPress:trunk' into fix-missing-alt-text
5f8a6ad
@devansh016
Update testcase
16fcca0
@AhmarZaidi
Update exit code
78b27ea
@AhmarZaidi
Remove string contains
33901cb
@westonruter
Merge pull request #1314 from AhmarZaidi/fix-plugin-test-error
b71d0a0 
Add error for incorrect test command usage
@AhmarZaidi
Add support for sending preload links via HTTP headers
7fdc181
@westonruter
Upgrade PHPStan to 1.11.6
70b8ed0
@westonruter
Refactor webp_uploads_update_image_references() to leverage HTML tag …
16e4054 
…processor and add tests
@westonruter
Appease PHPStan for not knowing that an offset exists
4354000
@westonruter
Eliminate unnecessary capture group
2eccdc7
@westonruter
Remove strict rule compliance to allow preg_match() array shape to co…
b05aeac 
…me through
@westonruter
Restore strict rule compliance
75cd653
@westonruter
Merge pull request #1325 from WordPress/upgrade/phpstan-1.11.6
1ed2fbd 
Upgrade PHPStan to 1.11.6
@westonruter
Generate phpunit-multisite.xml on the fly
9124db7
@devansh016
Remove unuse code
ed39189
@AhmarZaidi
PR Changes
1e3a242 
- Remove code duplication
- Update escaping functions
- Update documentation
- Handle no headers case
@AhmarZaidi
Merge branch 'trunk' into preload-links
e7103c6
@AhmarZaidi
Prepare links
b36959a 
- Deduplicate adjacent links
- Add media attributes
@mukeshpanchal27
Skip invalid mime type support tests
936bcb3
@devansh016
Add test for alt attribute and improve test for source
d529d9a
@devansh016
Merge branch 'trunk' into fix-missing-alt-text
3d6d3fe
mukeshpanchal27 and others added 6 commits July 9, 2024 11:15
@mukeshpanchal27
Update WP version in CONTRIBUTING.md
51d1594
@mukeshpanchal27
Merge pull request #1336 from WordPress/update/contributing-md
d1bbc24 
Update WP version in `CONTRIBUTING.md`
@devansh016 @westonruter
Improve testcase structure
04374f8 
Co-authored-by: Weston Ruter <westonruter@google.com>
@swissspidy @westonruter
Lowercase context
9506d51 
Co-authored-by: Weston Ruter <westonruter@google.com>
@westonruter
Merge pull request #1319 from devansh016/fix-missing-alt-text
37e6882 
Preserve alt text for picture elements
@westonruter
Merge pull request #1287 from alexclassroom/trunk
9b32767 
I18N: Add context to Modern Image Formats section title
adamsilverstein
adamsilverstein approved these changes Jul 9, 2024
View reviewed changes
Copy link
Member

@adamsilverstein adamsilverstein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@mukeshpanchal27 mukeshpanchal27 marked this pull request as ready for review July 9, 2024 15:38
@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 9, 2024 •
edited
Loading

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: alexclassroom <alexclassroom@git.wordpress.org>
Co-authored-by: AhmarZaidi <ahmarzaidi@git.wordpress.org>
Co-authored-by: devansh016 <devansh2002@git.wordpress.org>
Co-authored-by: westonruter <westonruter@git.wordpress.org>
Co-authored-by: mukeshpanchal27 <mukesh27@git.wordpress.org>
Co-authored-by: swissspidy <swissspidy@git.wordpress.org>
Co-authored-by: joemcgill <joemcgill@git.wordpress.org>
Co-authored-by: adamsilverstein <adamsilverstein@git.wordpress.org>
Co-authored-by: thelovekesh <thelovekesh@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

westonruter
westonruter reviewed Jul 9, 2024
View reviewed changes
westonruter
westonruter reviewed Jul 9, 2024
View reviewed changes
@joemcgill joemcgill changed the base branch from trunk to feature/more-accurate-sizes-attribute July 9, 2024 22:43
@joemcgill
Copy link
Member

Going to merge this change into the feature branch while we do final prep.

@joemcgill joemcgill merged commit b307a53 into feature/more-accurate-sizes-attribute Jul 9, 2024
@joemcgill joemcgill deleted the fix/1330-plugin-name branch July 9, 2024 22:45
@westonruter westonruter removed the no milestone PRs that do not have a defined milestone for release label Jul 10, 2024
@westonruter westonruter added this to the auto-sizes 1.1.0 milestone Jul 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@westonruter westonruter westonruter approved these changes

@adamsilverstein adamsilverstein adamsilverstein approved these changes

@thelovekesh thelovekesh thelovekesh approved these changes

@joemcgill joemcgill Awaiting requested review from joemcgill joemcgill is a code owner

@swissspidy swissspidy Awaiting requested review from swissspidy

Assignees

@joemcgill joemcgill

Labels
[Plugin] Enhanced Responsive Images Issues for the Enhanced Responsive Images plugin (formerly Auto Sizes) [Type] Enhancement A suggestion for improvement of an existing feature
Projects
None yet
Milestone
auto-sizes 1.1.0
Development

Successfully merging this pull request may close these issues.

Update plugin name for Initial work on Accurate Sizes in Auto Sizes Plugin
9 participants
@mukeshpanchal27 @joemcgill @westonruter @adamsilverstein @thelovekesh @alexclassroom @AhmarZaidi @devansh016 @swissspidy