Skip to content

Initial implementation of improved image sizes algorithm #1250

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Jun 5, 2024
Merged

Initial implementation of improved image sizes algorithm #1250

merged 9 commits into from
Jun 5, 2024

Conversation

mukeshpanchal27
Copy link
Member

Summary

Fixes #1187

@mukeshpanchal27 mukeshpanchal27 added [Type] Feature A new feature within an existing module no milestone PRs that do not have a defined milestone for release [Plugin] Enhanced Responsive Images Issues for the Enhanced Responsive Images plugin (formerly Auto Sizes) labels May 27, 2024
@mukeshpanchal27 mukeshpanchal27 self-assigned this May 27, 2024
@mukeshpanchal27 mukeshpanchal27 requested a review from joemcgill May 27, 2024 10:38
@joemcgill joemcgill linked an issue May 28, 2024 that may be closed by this pull request
Initial implementation of improved image sizes algorithm #1187
Closed
3 tasks
westonruter
westonruter reviewed May 28, 2024
View reviewed changes
westonruter
westonruter reviewed May 28, 2024
View reviewed changes
westonruter
westonruter reviewed May 28, 2024
View reviewed changes
joemcgill
joemcgill requested changes May 28, 2024
View reviewed changes
Copy link
Member

@joemcgill joemcgill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good start! I think it would be good to add some tests for these early on so we can make sure we're getting the output we expect.

@mukeshpanchal27 mukeshpanchal27 marked this pull request as ready for review June 3, 2024 08:11
@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 3, 2024

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: mukeshpanchal27 <mukesh27@git.wordpress.org>
Co-authored-by: westonruter <westonruter@git.wordpress.org>
Co-authored-by: joemcgill <joemcgill@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

joemcgill
joemcgill requested changes Jun 3, 2024
View reviewed changes
Copy link
Member

@joemcgill joemcgill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like a good first implementation and tests well. I've left a few suggestions about improving the tests, but I think this is pretty close to merge so we have a base in the feature branch to work against.

westonruter
westonruter reviewed Jun 3, 2024
View reviewed changes
westonruter
westonruter reviewed Jun 3, 2024
View reviewed changes
westonruter
westonruter reviewed Jun 4, 2024
View reviewed changes
joemcgill
joemcgill approved these changes Jun 4, 2024
View reviewed changes
Copy link
Member

@joemcgill joemcgill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor suggestion, but I think this is good. Pre-approving.

@mukeshpanchal27 mukeshpanchal27 merged commit 5f1664e into feature/more-accurate-sizes-attribute Jun 5, 2024
@mukeshpanchal27 mukeshpanchal27 deleted the fix/1187-accurate-sizes-image-cover-block branch June 5, 2024 04:18
@westonruter westonruter mentioned this pull request Jun 25, 2024
Closed
3 tasks
@westonruter westonruter removed the no milestone PRs that do not have a defined milestone for release label Jul 10, 2024
@westonruter westonruter added this to the auto-sizes 1.1.0 milestone Jul 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@westonruter westonruter westonruter approved these changes

@joemcgill joemcgill joemcgill approved these changes

Assignees

@mukeshpanchal27 mukeshpanchal27

Labels
[Plugin] Enhanced Responsive Images Issues for the Enhanced Responsive Images plugin (formerly Auto Sizes) [Type] Feature A new feature within an existing module
Projects
None yet
Milestone
auto-sizes 1.1.0
Development

Successfully merging this pull request may close these issues.

Initial implementation of improved image sizes algorithm
3 participants
@mukeshpanchal27 @westonruter @joemcgill