Update PHPStan level to 4 #1201

westonruter · 2024-05-04T00:52:25Z

This fixes the following PHPStan issues:

[ERROR] Found 65 errors

 ------ ------------------------------------------------------------------------------------------------------------------------------------------------- 
  Line   plugins/dominant-color-images/class-dominant-color-image-editor-gd.php                                                                           
 ------ ------------------------------------------------------------------------------------------------------------------------------------------------- 
  30     Negated boolean expression is always false.                                                                                                      
         💡 Because the type is coming from a PHPDoc, you can turn off this check by setting treatPhpDocTypesAsCertain: false in your phpstan.neon.dist.  
  60     Negated boolean expression is always false.                                                                                                      
         💡 Because the type is coming from a PHPDoc, you can turn off this check by setting treatPhpDocTypesAsCertain: false in your phpstan.neon.dist.  
 ------ ------------------------------------------------------------------------------------------------------------------------------------------------- 

 ------ ------------------------------------------------------------------------------------------------------------------------------------------------- 
  Line   plugins/dominant-color-images/class-dominant-color-image-editor-imagick.php                                                                      
 ------ ------------------------------------------------------------------------------------------------------------------------------------------------- 
  30     Negated boolean expression is always false.                                                                                                      
         💡 Because the type is coming from a PHPDoc, you can turn off this check by setting treatPhpDocTypesAsCertain: false in your phpstan.neon.dist.  
  62     Negated boolean expression is always false.                                                                                                      
         💡 Because the type is coming from a PHPDoc, you can turn off this check by setting treatPhpDocTypesAsCertain: false in your phpstan.neon.dist.  
  73     If condition is always true.                                                                                                                     
         💡 Because the type is coming from a PHPDoc, you can turn off this check by setting treatPhpDocTypesAsCertain: false in your phpstan.neon.dist.  
 ------ ------------------------------------------------------------------------------------------------------------------------------------------------- 

 ------ ------------------------------------------------------------------------------------------------------------------------------------------------------ 
  Line   plugins/dominant-color-images/helper.php                                                                                                              
 ------ ------------------------------------------------------------------------------------------------------------------------------------------------------ 
  136    Function dominant_color_get_dominant_color() never returns string so it can be removed from the return type.                                          
  145    Offset 'dominant_color' on array{width: int, height: int, file: string, sizes: array, image_meta: array, filesize: int} in isset() does not exist.    
  149    Unreachable statement - code above always terminates.                                                                                                 
  160    Function dominant_color_has_transparency() never returns bool so it can be removed from the return type.                                              
  166    Offset 'has_transparency' on array{width: int, height: int, file: string, sizes: array, image_meta: array, filesize: int} in isset() does not exist.  
  170    Unreachable statement - code above always terminates.                                                                                                 
 ------ ------------------------------------------------------------------------------------------------------------------------------------------------------ 

 ------ ----------------------------------------------------------------------------------------------------------------------------------------------------------------------- 
  Line   plugins/webp-uploads/helper.php                                                                                                                                        
 ------ ----------------------------------------------------------------------------------------------------------------------------------------------------------------------- 
  51     Call to function is_array() with array will always evaluate to true.                                                                                                   
         💡 Because the type is coming from a PHPDoc, you can turn off this check by setting treatPhpDocTypesAsCertain: false in your phpstan.neon.dist.                        
  145    Offset 'height' on array{width: int, height: int, crop: bool} in isset() always exists and is not nullable.                                                            
  146    Offset 'width' on array{width: int, height: int, crop: bool} in isset() always exists and is not nullable.                                                             
  147    Offset 'crop' on array{width: int, height: int, crop: bool} in isset() always exists and is not nullable.                                                              
  182    Offset 'path' on array{path: string, file: non-falsy-string, width: int, height: int, mime-type: string, filesize: int} in isset() always exists and is not nullable.  
  208    Negated boolean expression is always false.                                                                                                                            
         💡 Because the type is coming from a PHPDoc, you can turn off this check by setting treatPhpDocTypesAsCertain: false in your phpstan.neon.dist.                        
  288    Call to function is_array() with array will always evaluate to true.                                                                                                   
         💡 Because the type is coming from a PHPDoc, you can turn off this check by setting treatPhpDocTypesAsCertain: false in your phpstan.neon.dist.                        
 ------ ----------------------------------------------------------------------------------------------------------------------------------------------------------------------- 

 ------ ------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- 
  Line   plugins/webp-uploads/hooks.php                                                                                                                                                                                                       
 ------ ------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- 
  266    Offset 'function' on array{function: string, line?: int, file?: string, class?: class-string, type?: '->'|'::', args?: array, object?: object} in isset() always exists and is not nullable.                                         
  336    Negated boolean expression is always false.                                                                                                                                                                                          
         💡 Because the type is coming from a PHPDoc, you can turn off this check by setting treatPhpDocTypesAsCertain: false in your phpstan.neon.dist.                                                                                      
  628    Offset 'sizes' on array{width: int, height: int, file: non-falsy-string, sizes: array, image_meta: array, filesize: int, sources?: array<string, array{file: string, filesize: int}>} in isset() always exists and is not nullable.  
  628    Right side of && is always true.                                                                                                                                                                                                     
         💡 Because the type is coming from a PHPDoc, you can turn off this check by setting treatPhpDocTypesAsCertain: false in your phpstan.neon.dist.                                                                                      
 ------ ------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- 

 ------ ---------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- 
  Line   plugins/webp-uploads/image-edit.php                                                                                                                                                           
 ------ ---------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- 
  253    Offset 'function' on array{function: string, line?: int, file?: string, class?: class-string, type?: '->'|'::', args?: array, object?: object} in isset() always exists and is not nullable.  
 ------ ---------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- 

 ------ ------------------------------------------------------------------------------------------------------------------------------------------------- 
  Line   tests/includes/admin/load-tests.php                                                                                                              
 ------ ------------------------------------------------------------------------------------------------------------------------------------------------- 
  28     Call to method PHPUnit\Framework\Assert::assertArrayHasKey() with 'options-general.php' and array{} will always evaluate to false.               
         💡 Because the type is coming from a PHPDoc, you can turn off this check by setting treatPhpDocTypesAsCertain: false in your phpstan.neon.dist.  
 ------ ------------------------------------------------------------------------------------------------------------------------------------------------- 

 ------ ------------------------------------------------------------------------------------------------------------------------------------------------- 
  Line   tests/includes/admin/server-timing-tests.php                                                                                                     
 ------ ------------------------------------------------------------------------------------------------------------------------------------------------- 
  49     Call to method PHPUnit\Framework\Assert::assertArrayHasKey() with 'tools.php' and array{} will always evaluate to false.                         
         💡 Because the type is coming from a PHPDoc, you can turn off this check by setting treatPhpDocTypesAsCertain: false in your phpstan.neon.dist.  
  61     Call to method PHPUnit\Framework\Assert::assertArrayHasKey() with 'perflab-server…' and array{} will always evaluate to false.                   
         💡 Because the type is coming from a PHPDoc, you can turn off this check by setting treatPhpDocTypesAsCertain: false in your phpstan.neon.dist.  
  70     Call to method PHPUnit\Framework\Assert::assertArrayHasKey() with 'perflab-server…' and array{} will always evaluate to false.                   
         💡 Because the type is coming from a PHPDoc, you can turn off this check by setting treatPhpDocTypesAsCertain: false in your phpstan.neon.dist.  
 ------ ------------------------------------------------------------------------------------------------------------------------------------------------- 

 ------ -------------------------------------------------------------------------------------------------------------------------------------------------- 
  Line   tests/includes/server-timing/load-tests.php                                                                                                       
 ------ -------------------------------------------------------------------------------------------------------------------------------------------------- 
  15     Call to method PHPUnit\Framework\Assert::assertInstanceOf() with 'Perflab_Server_Timing' and Perflab_Server_Timing will always evaluate to true.  
  81     Call to method PHPUnit\Framework\Assert::assertTrue() with false will always evaluate to false.                                                   
  81     Offset 'perflab-server…' on array{} in isset() does not exist.                                                                                    
 ------ -------------------------------------------------------------------------------------------------------------------------------------------------- 

 ------ ------------------------------------------------------------------------------------------------------------------------- 
  Line   tests/includes/server-timing/perflab-server-timing-tests.php                                                             
 ------ ------------------------------------------------------------------------------------------------------------------------- 
  73     Call to method PHPUnit\Framework\Assert::assertTrue() with false and 'Measure callback…' will always evaluate to false.  
 ------ ------------------------------------------------------------------------------------------------------------------------- 

 ------ -------------------------------------------------------------------------------------------------------------------------------------------------------------- 
  Line   tests/includes/site-health/audit-enqueued-assets/audit-enqueued-assets-test.php                                                                               
 ------ -------------------------------------------------------------------------------------------------------------------------------------------------------------- 
  167    Call to method PHPUnit\Framework\Assert::assertIsArray() with array{direct: array<string, array{label: string, test: string}>} will always evaluate to true.  
 ------ -------------------------------------------------------------------------------------------------------------------------------------------------------------- 

 ------ ------------------------------------------------------------------------------------------------------------------------------------------------- 
  Line   tests/plugins/optimization-detective/storage/data-tests.php                                                                                      
 ------ ------------------------------------------------------------------------------------------------------------------------------------------------- 
  533    Call to method PHPUnit\Framework\Assert::assertTrue() with true will always evaluate to true.                                                    
         💡 Because the type is coming from a PHPDoc, you can turn off this check by setting treatPhpDocTypesAsCertain: false in your phpstan.neon.dist.  
  533    Result of || is always true.                                                                                                                     
         💡 Because the type is coming from a PHPDoc, you can turn off this check by setting treatPhpDocTypesAsCertain: false in your phpstan.neon.dist.  
  533    Strict comparison using === between false and false will always evaluate to true.                                                                
         💡 Because the type is coming from a PHPDoc, you can turn off this check by setting treatPhpDocTypesAsCertain: false in your phpstan.neon.dist.  
  535    Call to method PHPUnit\Framework\Assert::assertIsString() with string will always evaluate to true.                                              
         💡 Because the type is coming from a PHPDoc, you can turn off this check by setting treatPhpDocTypesAsCertain: false in your phpstan.neon.dist.  
 ------ ------------------------------------------------------------------------------------------------------------------------------------------------- 

 ------ ------------------------------------------------------------------------------------------------------------------------------------------------- 
  Line   tests/plugins/speculation-rules/speculation-rules-helper-test.php                                                                                
 ------ ------------------------------------------------------------------------------------------------------------------------------------------------- 
  37     Call to method PHPUnit\Framework\Assert::assertIsArray() with array will always evaluate to true.                                                
         💡 Because the type is coming from a PHPDoc, you can turn off this check by setting treatPhpDocTypesAsCertain: false in your phpstan.neon.dist.  
 ------ ------------------------------------------------------------------------------------------------------------------------------------------------- 

 ------ --------------------------------------------------------------------------------------------------------------------------------------------------- 
  Line   tests/plugins/webp-uploads/helper-tests.php                                                                                                        
 ------ --------------------------------------------------------------------------------------------------------------------------------------------------- 
  101    Call to method PHPUnit\Framework\Assert::assertIsArray() with array{file: string, filesize: int} will always evaluate to true.                     
  102    Call to method PHPUnit\Framework\Assert::assertArrayHasKey() with 'filesize' and array{file: string, filesize: int} will always evaluate to true.  
         💡 Because the type is coming from a PHPDoc, you can turn off this check by setting treatPhpDocTypesAsCertain: false in your phpstan.neon.dist.    
  103    Call to method PHPUnit\Framework\Assert::assertArrayHasKey() with 'file' and array{file: string, filesize: int} will always evaluate to true.      
         💡 Because the type is coming from a PHPDoc, you can turn off this check by setting treatPhpDocTypesAsCertain: false in your phpstan.neon.dist.    
  128    Call to method PHPUnit\Framework\Assert::assertIsArray() with array{file: string, filesize: int} will always evaluate to true.                     
  129    Call to method PHPUnit\Framework\Assert::assertArrayHasKey() with 'filesize' and array{file: string, filesize: int} will always evaluate to true.  
         💡 Because the type is coming from a PHPDoc, you can turn off this check by setting treatPhpDocTypesAsCertain: false in your phpstan.neon.dist.    
  130    Call to method PHPUnit\Framework\Assert::assertArrayHasKey() with 'file' and array{file: string, filesize: int} will always evaluate to true.      
         💡 Because the type is coming from a PHPDoc, you can turn off this check by setting treatPhpDocTypesAsCertain: false in your phpstan.neon.dist.    
  292    Call to method PHPUnit\Framework\Assert::assertArrayHasKey() with 'filesize' and array{file: string, filesize: int} will always evaluate to true.  
         💡 Because the type is coming from a PHPDoc, you can turn off this check by setting treatPhpDocTypesAsCertain: false in your phpstan.neon.dist.    
  293    Call to method PHPUnit\Framework\Assert::assertArrayHasKey() with 'file' and array{file: string, filesize: int} will always evaluate to true.      
         💡 Because the type is coming from a PHPDoc, you can turn off this check by setting treatPhpDocTypesAsCertain: false in your phpstan.neon.dist.    
  326    Call to method PHPUnit\Framework\Assert::assertArrayHasKey() with 'filesize' and array{file: string, filesize: int} will always evaluate to true.  
         💡 Because the type is coming from a PHPDoc, you can turn off this check by setting treatPhpDocTypesAsCertain: false in your phpstan.neon.dist.    
  328    Call to method PHPUnit\Framework\Assert::assertArrayHasKey() with 'file' and array{file: string, filesize: int} will always evaluate to true.      
         💡 Because the type is coming from a PHPDoc, you can turn off this check by setting treatPhpDocTypesAsCertain: false in your phpstan.neon.dist.    
  370    Call to method PHPUnit\Framework\Assert::assertIsArray() with array<string, array<string>> will always evaluate to true.                           
         💡 Because the type is coming from a PHPDoc, you can turn off this check by setting treatPhpDocTypesAsCertain: false in your phpstan.neon.dist.    
  390    Call to method PHPUnit\Framework\Assert::assertIsArray() with array<string, array<string>> will always evaluate to true.                           
         💡 Because the type is coming from a PHPDoc, you can turn off this check by setting treatPhpDocTypesAsCertain: false in your phpstan.neon.dist.    
  409    Call to method PHPUnit\Framework\Assert::assertIsArray() with array<string, array<string>> will always evaluate to true.                           
         💡 Because the type is coming from a PHPDoc, you can turn off this check by setting treatPhpDocTypesAsCertain: false in your phpstan.neon.dist.    
  428    Call to method PHPUnit\Framework\Assert::assertIsArray() with array<string, array<string>> will always evaluate to true.                           
         💡 Because the type is coming from a PHPDoc, you can turn off this check by setting treatPhpDocTypesAsCertain: false in your phpstan.neon.dist.    
  444    Call to method PHPUnit\Framework\Assert::assertIsArray() with array<string, array<string>> will always evaluate to true.                           
         💡 Because the type is coming from a PHPDoc, you can turn off this check by setting treatPhpDocTypesAsCertain: false in your phpstan.neon.dist.    
 ------ --------------------------------------------------------------------------------------------------------------------------------------------------- 

 ------ ---------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- 
  Line   tests/plugins/webp-uploads/image-edit-tests.php                                                                                                                                                                                                                             
 ------ ---------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- 
  40     Call to method PHPUnit\Framework\Assert::assertIsArray() with Countable will always evaluate to false.                                                                                                                                                                      
  44     Call to method PHPUnit\Framework\Assert::assertArrayHasKey() with 'full-orig' and array{} will always evaluate to false.                                                                                                                                                    
         💡 Because the type is coming from a PHPDoc, you can turn off this check by setting treatPhpDocTypesAsCertain: false in your phpstan.neon.dist.                                                                                                                             
  54     Call to method PHPUnit\Framework\Assert::assertArrayHasKey() with 'sources' and *NEVER* will always evaluate to true.                                                                                                                                                       
         💡 Because the type is coming from a PHPDoc, you can turn off this check by setting treatPhpDocTypesAsCertain: false in your phpstan.neon.dist.                                                                                                                             
  277    Call to method PHPUnit\Framework\Assert::assertArrayHasKey() with 'original_image' and array{width: int, height: int, file: string, sizes: array, image_meta: array, filesize: int, sources?: array<string, array{file: string, filesize: int}>}|null will always evaluate  
         to false.                                                                                                                                                                                                                                                                   
         💡 Because the type is coming from a PHPDoc, you can turn off this check by setting treatPhpDocTypesAsCertain: false in your phpstan.neon.dist.                                                                                                                             
  278    Call to method PHPUnit\Framework\Assert::assertArrayHasKey() with 'sources' and *NEVER* will always evaluate to true.                                                                                                                                                       
         💡 Because the type is coming from a PHPDoc, you can turn off this check by setting treatPhpDocTypesAsCertain: false in your phpstan.neon.dist.                                                                                                                             
  287    Call to method PHPUnit\Framework\Assert::assertArrayHasKey() with 'sizes' and *NEVER* will always evaluate to true.                                                                                                                                                         
         💡 Because the type is coming from a PHPDoc, you can turn off this check by setting treatPhpDocTypesAsCertain: false in your phpstan.neon.dist.                                                                                                                             
  327    Call to method PHPUnit\Framework\Assert::assertArrayHasKey() with 'sizes' and array{width: int, height: int, file: string, sizes: array, image_meta: array, filesize: int, sources: array<string, array{file: string, filesize: int}>} will always evaluate to true.        
         💡 Because the type is coming from a PHPDoc, you can turn off this check by setting treatPhpDocTypesAsCertain: false in your phpstan.neon.dist.                                                                                                                             
  493    Call to method PHPUnit\Framework\Assert::assertSame() with 'full-orig' and 'full-orig' will always evaluate to true.                                                                                                                                                        
 ------ ---------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- 

 ------ ------------------------------------------------------------------------------------------------------------------------------------------------- 
  Line   tests/plugins/webp-uploads/load-tests.php                                                                                                        
 ------ ------------------------------------------------------------------------------------------------------------------------------------------------- 
  250    Call to method PHPUnit\Framework\Assert::assertIsArray() with array<string, array{file: string, filesize: int}> will always evaluate to true.    
         💡 Because the type is coming from a PHPDoc, you can turn off this check by setting treatPhpDocTypesAsCertain: false in your phpstan.neon.dist.  
  705    Call to method PHPUnit\Framework\Assert::assertIsArray() with array<string, array{file: string, filesize: int}> will always evaluate to true.    
         💡 Because the type is coming from a PHPDoc, you can turn off this check by setting treatPhpDocTypesAsCertain: false in your phpstan.neon.dist.  
 ------ ------------------------------------------------------------------------------------------------------------------------------------------------- 

 ------ ------------------------------------------------------------------------------------------------------------------------------------------------- 
  Line   tests/utils/Constraint/ImageHasSource.php                                                                                                        
 ------ ------------------------------------------------------------------------------------------------------------------------------------------------- 
  72     Offset 'sources' on array{width: int, height: int, file: string, sizes: array, image_meta: array, filesize: int} in isset() does not exist.      
  72     Result of || is always true.                                                                                                                     
         💡 Because the type is coming from a PHPDoc, you can turn off this check by setting treatPhpDocTypesAsCertain: false in your phpstan.neon.dist.  
  78     Unreachable statement - code above always terminates.                                                                                            
 ------ -------------------------------------------------------------------------------------------------------------------------------------------------

Please review individual commits for changes.

…esponse

… update/phpstan-level-4 * 'trunk' of https://github.com/WordPress/performance: Fix offset does not exist on array in test Fix variable in empty() always exists and is not falsy Use function stub to override filtered return value typing Revert "Add typing for attachment metadata added by webp-uploads" Revert "Add typing for attachment metadata added by Dominant Color Images" Update comment to reference visibility instead of opacity Use visibility:hidden instead of opacity:0 Clarify Chromium behavior in comment Add optimization_detective_disabled query var to disable behavior Add pointer-events:none to the iframe Hide post embed iframes with opacity instead of clipping

westonruter · 2024-05-06T20:53:07Z

tests/includes/server-timing/perflab-server-timing-tests.php

 		$this->assertTrue( $this->server_timing->has_registered_metric( 'test-metric' ), 'Metric without cap should still be registered' );
 		$this->assertFalse( $called, 'Measure callback without cap must not be run' );

 		wp_set_current_user( self::$admin_id );
-		$this->server_timing->register_metric( 'test-metric-2', $args );


Without passing the callback here, PHPStan isn't aware that the $called variable could actually have changed so it complains:

Call to method PHPUnit\Framework\Assert::assertTrue() with false and 'Measure callback…' will always evaluate to false.

westonruter · 2024-05-06T20:54:02Z

tests/plugins/webp-uploads/image-edit-tests.php

+		$this->assertArrayHasKey( 'full-orig', $backup_sizes );
+		$this->assertArrayHasKey( 'thumbnail-orig', $backup_sizes );
+		$this->assertArrayHasKey( 'medium-orig', $backup_sizes );
+		$this->assertArrayHasKey( 'medium_large-orig', $backup_sizes );
+		$this->assertArrayHasKey( 'large-orig', $backup_sizes );


Without assertions like this, PHPStan complains about the foreach() loop below being passed $backup_sizes as an empty array.

westonruter · 2024-05-06T20:54:19Z

tests/plugins/webp-uploads/image-edit-tests.php

@@ -489,9 +493,7 @@ public function it_should_store_the_next_image_hash_on_the_backup_sources() {
 		$this->assertIsArray( $backup_sources );
 		$this->assertCount( 2, $backup_sources );
 		foreach ( array_keys( $backup_sources ) as $name ) {
-			if ( 'full-orig' === $name ) {
-				$this->assertSame( 'full-orig', $name );


Clearly this will always be the same 😄

westonruter · 2024-05-06T20:54:58Z

includes/server-timing/load.php

+function perflab_server_timing_init(): void {
+	perflab_server_timing();
+}
+
+add_action( 'wp_loaded', 'perflab_server_timing_init' );


This just avoids the need to ignore the PHPStan error about an action callback returning a value.

github-actions · 2024-05-06T20:55:39Z

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: westonruter <westonruter@git.wordpress.org>
Co-authored-by: mukeshpanchal27 <mukesh27@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

Bump PHPStan level to 4

fedc1a3

westonruter added the [Type] Bug An existing feature is broken label May 4, 2024

westonruter added this to the performance-lab 3.1.0 milestone May 4, 2024

Add treatPhpDocTypesAsCertain:false to fix 54 issues

fd32612

westonruter mentioned this pull request May 4, 2024

Increase PHPStan to rule level to 1 (and beyond) #775

Closed

13 tasks

westonruter changed the title ~~Bump PHPStan level to 4~~ Update PHPStan level to 4 May 4, 2024

This comment was marked as resolved.

Sign in to view

Remove needless isset() check for function key in debug_backtrace() r…

d6e5757

…esponse

Base automatically changed from update/phpstan-level-3 to trunk May 6, 2024 19:47

westonruter added 5 commits May 6, 2024 12:48

Eliminate ignoring phpstan error

f4c9b51

Remove assertions which are always true

6b0d7d2

Improve specificity of assertions

8d22d9f

Work around PHPStan not being aware of callback being called

80eb27e

westonruter force-pushed the update/phpstan-level-4 branch from 02e26cd to 80eb27e Compare May 6, 2024 20:51

westonruter commented May 6, 2024

View reviewed changes

westonruter marked this pull request as ready for review May 6, 2024 20:55

westonruter requested review from adamsilverstein, felixarntz and manuelRod as code owners May 6, 2024 20:55

westonruter requested a review from thelovekesh May 6, 2024 20:55

westonruter requested a review from mukeshpanchal27 May 6, 2024 20:55

westonruter mentioned this pull request May 6, 2024

Update PHPStan level to 5 #1202

Merged

mukeshpanchal27 approved these changes May 7, 2024

View reviewed changes

westonruter merged commit 6c98aa0 into trunk May 7, 2024

westonruter deleted the update/phpstan-level-4 branch May 7, 2024 16:35

westonruter added the skip changelog PRs that should not be mentioned in changelogs label May 17, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Update PHPStan level to 4 #1201

Update PHPStan level to 4 #1201

Uh oh!

westonruter commented May 4, 2024 •

edited

Loading

Uh oh!

This comment was marked as resolved.

westonruter May 6, 2024

Uh oh!

westonruter May 6, 2024

Uh oh!

westonruter May 6, 2024

Uh oh!

westonruter May 6, 2024

Uh oh!

github-actions bot commented May 6, 2024 •

edited

Loading

Uh oh!

Uh oh!

Update PHPStan level to 4 #1201

Update PHPStan level to 4 #1201

Uh oh!

Conversation

westonruter commented May 4, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

This comment was marked as resolved.

westonruter May 6, 2024

Choose a reason for hiding this comment

Uh oh!

westonruter May 6, 2024

Choose a reason for hiding this comment

Uh oh!

westonruter May 6, 2024

Choose a reason for hiding this comment

Uh oh!

westonruter May 6, 2024

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented May 6, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

westonruter commented May 4, 2024 •

edited

Loading

github-actions bot commented May 6, 2024 •

edited

Loading