Skip to content

Rename "Image Loading Optimization" to "Optimization Detective" #1041

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 12 commits into from
Mar 18, 2024
Merged

Rename "Image Loading Optimization" to "Optimization Detective" #1041

merged 12 commits into from
Mar 18, 2024

Conversation

westonruter
Copy link
Member

@westonruter westonruter commented Mar 9, 2024 •
edited
Loading

Checklist

  • PR has either [Focus] or Infrastructure label.
  • PR has a [Type] label.
  • PR has a milestone or the no milestone label.

@westonruter westonruter added [Type] Enhancement A suggestion for improvement of an existing feature [Focus] Images no milestone PRs that do not have a defined milestone for release [Plugin] Optimization Detective Issues for the Optimization Detective plugin labels Mar 9, 2024
@westonruter westonruter marked this pull request as ready for review March 9, 2024 09:31
@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 9, 2024 •
edited
Loading

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: westonruter <westonruter@git.wordpress.org>
Co-authored-by: mukeshpanchal27 <mukesh27@git.wordpress.org>
Co-authored-by: felixarntz <flixos90@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@westonruter westonruter mentioned this pull request Mar 10, 2024
Merged
3 tasks
mukeshpanchal27
mukeshpanchal27 reviewed Mar 11, 2024
View reviewed changes
.github/CODEOWNERS Outdated
Comment on lines 64 to 65
/plugins/optimization-detective @westonruter
/tests/plugins/optimization-detective @westonruter
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit-pick, let's align the spacing with the other entries.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated in 44a032f

plugins/optimization-detective/can-load.php Outdated
@@ -3,7 +3,7 @@
* Can load function to determine if ILO can load.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we still need can-load for plugin?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point! This is only for modules. Removed in 2106b9a.

plugins/optimization-detective/class-od-data-validation-exception.php Outdated
*
* @package image-loading-optimization
* @package optimization-detective
* @since n.e.x.t
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

n.e.x.t should be updated to a specific version number.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated in 30e6b96.

But when do we use n.e.x.t then?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apologies for the delayed response. The current npm run since -- -r {version} command runs on the entire file system and updates the same version. Therefore, if we use this command for Performance Lab file changes, it will also update the same version in other plugins, such as this one. We need to enhance that command to update the version for the plugin based on its configuration. In the meantime, we should use the actual version.

Base automatically changed from update/ilo-module-to-plugin to feature/image-loading-optimization March 11, 2024 16:27
westonruter and others added 4 commits March 11, 2024 09:31
@westonruter
Remove obsolete can-load.php
2106b9a 
Co-authored-by: mukeshpanchal27 <mukesh27@git.wordpress.org>
@westonruter
Update alignment in CODEOWNERS
44a032f 
Co-authored-by: mukeshpanchal27 <mukesh27@git.wordpress.org>
@westonruter
Replace n.e.x.t with with 0.1.0 version
30e6b96 
Co-authored-by: mukeshpanchal27 <mukesh27@git.wordpress.org>
@westonruter
Merge branch 'feature/image-loading-optimization' into update/ilo-to-…
6a7458b 
…optimization-detective
@westonruter westonruter mentioned this pull request Mar 11, 2024
Closed
25 tasks
felixarntz
felixarntz reviewed Mar 11, 2024
View reviewed changes
Copy link
Member

@felixarntz felixarntz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't reviewed the PR, but we just had a conversation about our plugin names this morning, and this name here isn't necessarily a good idea IMO.

I just opened #1046 to discuss more holistically.

@westonruter westonruter mentioned this pull request Mar 14, 2024
Closed
@westonruter westonruter requested a review from felixarntz March 18, 2024 19:32
felixarntz
felixarntz reviewed Mar 18, 2024
View reviewed changes
Copy link
Member

@felixarntz felixarntz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@westonruter Almost LGTM. Just a few small things.

@westonruter westonruter requested a review from felixarntz March 18, 2024 21:49
@felixarntz felixarntz merged commit 024d9c2 into feature/image-loading-optimization Mar 18, 2024
@felixarntz felixarntz deleted the update/ilo-to-optimization-detective branch March 18, 2024 21:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mukeshpanchal27 mukeshpanchal27 mukeshpanchal27 left review comments

@felixarntz felixarntz felixarntz approved these changes

Assignees
No one assigned
Labels
no milestone PRs that do not have a defined milestone for release [Plugin] Optimization Detective Issues for the Optimization Detective plugin [Type] Enhancement A suggestion for improvement of an existing feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@westonruter @felixarntz @mukeshpanchal27