Keep timestamps current for URL Metrics in fixture #1913
Conversation
Addresses oversight from #1903
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## trunk #1913 +/- ##
=======================================
Coverage 69.62% 69.62%
=======================================
Files 86 86
Lines 6990 6990
=======================================
Hits 4867 4867
Misses 2123 2123
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This addresses an oversight from #1903. When I captured the URL Metrics in the fixture, the
timestampvalues were all newer than 1 week, so they were all considered fresh. However, after a weektest_get_lcp_element_when_group_half_stalestarted to fail because the URL Metrics would never be half stale anymore due to a different ETag: They would be completely stale due to having timestmaps older than the freshness TTL of one week.