Skip to content

Wrap ABSPATH existence short-circuit with code coverage ignore comments #1815

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 21, 2025
Merged

Wrap ABSPATH existence short-circuit with code coverage ignore comments #1815

merged 1 commit into from
Jan 21, 2025

Conversation

westonruter
Copy link
Member

This addresses the first point of #1789: "Ignore Coverage for Non-Critical Code Blocks"

@westonruter westonruter added [Type] Enhancement A suggestion for improvement of an existing feature no milestone PRs that do not have a defined milestone for release skip changelog PRs that should not be mentioned in changelogs labels Jan 21, 2025
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 21, 2025 •
edited
Loading

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: westonruter <westonruter@git.wordpress.org>
Co-authored-by: felixarntz <flixos90@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@westonruter westonruter mentioned this pull request Jan 21, 2025
Open
felixarntz
felixarntz approved these changes Jan 21, 2025
View reviewed changes
Copy link
Member

@felixarntz felixarntz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @westonruter!

This was referenced Jan 21, 2025
Merged
Merged
@codecov Codecov
Copy link

codecov bot commented Jan 21, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 59.58%. Comparing base (c270c43) to head (95884d6).
Report is 2 commits behind head on trunk.

Additional details and impacted files 
@@            Coverage Diff             @@
##            trunk    #1815      +/-   ##
==========================================
+ Coverage   58.26%   59.58%   +1.32%     
==========================================
  Files          85       84       -1     
  Lines        6670     6522     -148     
==========================================
  Hits         3886     3886              
+ Misses       2784     2636     -148
Flag Coverage Δ
multisite 59.58% <ø> (+1.32%) ⬆️
single 36.09% <ø> (+0.83%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@westonruter westonruter mentioned this pull request Jan 21, 2025
Open
@westonruter westonruter merged commit 6803bc9 into trunk Jan 21, 2025
22 checks passed
@westonruter westonruter deleted the add/code-coverage-ignore-abspath-short-circuit branch January 21, 2025 18:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@felixarntz felixarntz felixarntz approved these changes

@adamsilverstein adamsilverstein Awaiting requested review from adamsilverstein adamsilverstein is a code owner

@pbearne pbearne Awaiting requested review from pbearne pbearne is a code owner

@joemcgill joemcgill Awaiting requested review from joemcgill joemcgill is a code owner

@mukeshpanchal27 mukeshpanchal27 Awaiting requested review from mukeshpanchal27 mukeshpanchal27 is a code owner

@manuelRod manuelRod Awaiting requested review from manuelRod manuelRod is a code owner

Assignees
No one assigned
Labels
no milestone PRs that do not have a defined milestone for release skip changelog PRs that should not be mentioned in changelogs [Type] Enhancement A suggestion for improvement of an existing feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@westonruter @felixarntz