-
Notifications
You must be signed in to change notification settings - Fork 133
Description
As discussed in the Performance chat on April 25, the SQLite feature will going forward no longer be directly associated with the Core Performance Team. This is mostly because it is not itself a performance focused feature. Its effects on performance are certainly considerable, but to assume that the primary reason for a site to use SQLite is performance would be wrong.
The Core Performance Team still intends to support the project and help assess its performance in the future, but it will no longer be directly tied to the team in terms of responsibility and maintenance.
The SQLite standalone plugin has already existed for several months at this point, and the duplicate codebases between the standalone plugin's GitHub repository and the Performance Lab module code has been confusing and problematic to handle. This issue therefore focuses on introducing a notice to administrators on sites where the Performance Lab module is active to migrate to the standalone plugin instead.
This notice should be launched as part of the upcoming Performance Lab 2.4 release (June 19), so that the module can then be completely removed from Performance Lab in the 2.5 release (July 17).
Note that this effort is decoupled from #656, since the SQLite module is not being removed as part of that effort, but rather simply due to the above decision. So it shouldn't need to be blocked by the efforts in the greater unbundling effort.
Requirements
- Implement a WordPress admin notice (in "warning" style) that conditionally shows as long as the SQLite module is active:
- The notice should be displayed to all users that can
activate_plugins
, and it should explain that the SQLite module will be removed in the upcoming 2.5 release of Performance Lab. - If the SQLite standalone plugin is not installed, the notice should prompt the user to install and activate it, and then disable the SQLite module in Performance Lab.
- Else if the SQLite standalone plugin is not active, the notice should prompt the user to activate it and then disable the SQLite module in Performance Lab.
- Else the notice should prompt the user to disable the SQLite module in Performance Lab.
- The notice should be displayed to all users that can
- Implement a WordPress admin pointer pointing to the Performance Lab's submenu item (like the existing pointer) which should show under the same conditions as the existing pointer, but only if the SQLite module is active:
- It should simply inform the user that the SQLite module will be removed and that an action is necessary to keep its functionality.
- The admin notice should be the source of truth, so the pointer content should be kept brief. It is just added to put more attention to it, since admin notices are so heavily used that they may go unnoticed (which defeats their purpose).
- In the case that both admin pointers would be relevant to show, the new pointer should take precedence as it contains more urgent information.