-
Notifications
You must be signed in to change notification settings - Fork 133
Closed
Labels
InfrastructureIssues for the overall performance plugin infrastructureIssues for the overall performance plugin infrastructure[Plugin] Performance LabIssue relates to work in the Performance Lab Plugin onlyIssue relates to work in the Performance Lab Plugin only[Type] FeatureA new feature within an existing moduleA new feature within an existing module
Milestone
Description
Feature Description
Issues with static analysis were reported in #622 and fixed in #645 without actually incorporating PHPStan. Is there a reason why this wasn't done?
I suggest we incorporate szepeviktor/phpstan-wordpress into the tooling alongside PHPCS. This will ensure we catch more static analysis issues. While the plugin currently passes level 0 well enough, there are much more issues to find in the higher levels.
I'm happy to work on a PR if desired.
felixarntz, joemcgill, szepeviktor, lkraav, thelovekesh and 1 more
Metadata
Metadata
Assignees
Labels
InfrastructureIssues for the overall performance plugin infrastructureIssues for the overall performance plugin infrastructure[Plugin] Performance LabIssue relates to work in the Performance Lab Plugin onlyIssue relates to work in the Performance Lab Plugin only[Type] FeatureA new feature within an existing moduleA new feature within an existing module