@merkys7 @mukeshpanchal27 @bethanylang I definitely support expanding our GitHub workflow to test using additional PHP versions. However I have some specific feedback:

We should not test for every supported PHP version as that would take way too long and not really help that much. I would instead choose 3 very different PHP versions and limit testing to those, for example the latest (for now 8.1), the oldest supported (for now 5.6) and something in between (for now e.g. 7.4).
We should expand and follow the setup in our existing GitHub action rather than creating something from scratch, most importantly we should keep using @wordpress/env which ensures we maintain our very easy-to-configure setup and don't have to manually maintain a Docker configuration etc.
Looking at the @wordpress/env documentation linked above, it looks like we can set a WP_ENV_PHP_VERSION environment variable to force the PHP version to a specific version. So I think we can modify our existing https://github.com/WordPress/performance/blob/trunk/.github/workflows/php-test.yml to include a matrix of PHP versions and then use the above environment variable to set up @wordpress/env correctly.

Let me know your thoughts.

Run PHP unit tests in different versions of PHP #399

Description

Feature Description

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions