Skip to content

Conversation

t-hamano
Copy link
Contributor

@t-hamano t-hamano commented Mar 9, 2022

See: #39310

What?

This PR disables HTML editing support for gallery blocks.

Why?

In the gallery block, the block is broken when entering HTML edit mode and then returning to visual edit mode.
But gallery blocks with child blocks (core/image) should not be edited as HTML, just like group and column blocks.

How?

Testing Instructions

  1. Insert a gallery block.
  2. Make sure that the "Edit as HTML" menu is not displayed in the block toolbar option.

@t-hamano t-hamano marked this pull request as ready for review March 9, 2022 15:58
@Mamaduka Mamaduka added [Block] Gallery Affects the Gallery Block - used to display groups of images [Type] Bug An existing feature does not function as intended labels Mar 9, 2022
Copy link
Member

@Mamaduka Mamaduka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good to me. Thanks, @t-hamano 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Gallery Affects the Gallery Block - used to display groups of images [Type] Bug An existing feature does not function as intended
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Gallery block: Block is broken when returning from HTML edit mode to visual edit mode
3 participants