-
Notifications
You must be signed in to change notification settings - Fork 4.6k
Try allowing tab into block placeholder #39085
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Size Change: +11 B (0%) Total Size: 1.15 MB
ℹ️ View Unchanged
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested this out and it works absolutely perfectly! 👍 Certainly much better than the way it worked before 100%.
Amazing what a few lines of changes makes. Thanks!
@tellthemachines I also wanted to mention that it would still be cool to figure out how to land my PR you linked in the description. The reason being is pressing Tab is not obvious to new users and I think we can do better. Besides, if Tab drops us in the right spot, surely we can get it right with focus as well? I don't see a problem having this in for now but I'd really like to see my PR land. This will be necessary anyway for other problems faced with the setting in question so regardless we'll be better off. |
@alexstine thanks for the feedback! I'll have another look at your PR next and see if we can sort out the test failures. |
Description
Fixes #36710; possible alternative to #37934.
When focus is on a block with a placeholder (e.g. Image or Columns block) and we are in Edit mode, we should be able to Tab into the placeholder controls. This makes the placeholder controls keyboard accessible when the "Contain text cursor inside block" preference is enabled (arrow key navigation in or out of a block doesn't work with that preference). It also makes it possible to tab into a block that only contains a block inserter, such as an empty Group block.
Testing Instructions
Screenshots
Types of changes
Bug fix (non-breaking change which fixes an issue
Checklist:
*.native.js
files for terms that need renaming or removal).