Try: extract template metadata from the HTML files directly #38984
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @mcsf @mtias @youknowriad is this worth exploring further? |
oandregal
commented
Feb 22, 2022
| @@ -323,7 +323,18 @@ function _get_block_templates_files( $template_type ) { | |||
| ); | |||
|
|
|||
| if ( 'wp_template_part' === $template_type ) { | |||
| $template_files[] = _add_block_template_part_area_info( $new_template_item ); | |||
| $default_headers = array( | |||
There was a problem hiding this comment.
Before looking at implementation, I'd like to confirm direction. This is just a way to make this work for testing.
|
Yes, I think this is worth exploring in the broad context of clarifying and improving the folder structure and auto-load mechanisms (patterns, templates, styles). |
This was referenced Feb 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Spin-off from #36751
The templates & parts of block themes are declared via
.htmlfiles. The metadata for each of those files (translatable title, area, post types, etc) is provided via an external file, thetheme.json(seecustomTemplatesandtemplatePartskeys). This PR explores pulling metadata directly from the.htmlfiles, spinning off from #36751Each template & part would add a top-level comment such as:
How to test
parts/header.htmlfile in the theme directory:trunk, it'd be "header".TODO and related work.
wp-cli: implement extracting the fields available for translation from the.htmltemplates.theme.jsonmechanism if no metadata was found in the template & part.