UnitControl: Add __unstableInputWidth to prop types #38429
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7 tasks
andrewserong
approved these changes
Feb 2, 2022
There was a problem hiding this comment.
Good catch, thanks @aaronrobertshaw! This is a property we need exposed on the UnitControl component, so adding it in here makes good sense to me 👍
✅ Confirmed the __unstableInputWidth prop's type for the UnitControl matches the InputControl's.
✅ Checked there are no errors when running npm run build:package-types
✅ Tested that the UnitControl continues to function in the Storybook: npm run storybook:dev and in real world usage in the editor (e.g. padding / cover block min height)
LGTM!
8 tasks
|
Changelog for this will be added via: #38469 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related: #37769
Description
The
UnitControlpasses through props to an underlyingInputControlcomponent. TheInputControlaccepts an__unstabledInputWidthprop while theUnitControltypes omit this.This PR adds
__unstableInputWidthto theUnitControlPropstype.Testing Instructions
__unstableInputWidthprop's type for theUnitControlmatches theInputControl's.npm run build:package-typesUnitControlcontinues to function in the Storybook:npm run storybook:devTypes of changes
Bug fix.
Checklist:
*.native.jsfiles for terms that need renaming or removal).