Site Editor: Fix template author avatar check #37458
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jameskoster, do you think we should display a fallback icon in this case? |
|
Comment Author Avatar seems like a good candidate. |
|
Size Change: +230 B (0%) Total Size: 1.13 MB
ℹ️ View Unchanged
|
|
Looks much better 😄 |
kevin940726
reviewed
Dec 16, 2021
|
Thanks for fixing this. I completely forgot about a similar fix I worked on. This PR reminded me so I've pushed the branch - #37474. The changes there should make this fix easier. I can't remember if I'd finished it though, so let me familarise myself again. |
Co-authored-by: Kai Hao <kevin830726@gmail.com>
Co-authored-by: Kai Hao <kevin830726@gmail.com>
484b829 to
e38aa82
Compare
|
PR is ready for final review and merging. |
tellthemachines
pushed a commit
that referenced
this pull request
Dec 21, 2021
* Site Editor: Fix template author avatar check * Fallback to icon * Update packages/edit-site/src/components/list/added-by.js Co-authored-by: Kai Hao <kevin830726@gmail.com> * Update packages/edit-site/src/components/list/added-by.js Co-authored-by: Kai Hao <kevin830726@gmail.com> * Use avatarURL Co-authored-by: Kai Hao <kevin830726@gmail.com>
anton-vlasenko
pushed a commit
that referenced
this pull request
Dec 22, 2021
* Site Editor: Fix template author avatar check * Fallback to icon * Update packages/edit-site/src/components/list/added-by.js Co-authored-by: Kai Hao <kevin830726@gmail.com> * Update packages/edit-site/src/components/list/added-by.js Co-authored-by: Kai Hao <kevin830726@gmail.com> * Use avatarURL Co-authored-by: Kai Hao <kevin830726@gmail.com>
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes #37452
Fixes error on Template list screen when user avatars are disabled.
How has this been tested?
Screenshots
Types of changes
Bugfix
Checklist:
*.native.jsfiles for terms that need renaming or removal).