-
Notifications
You must be signed in to change notification settings - Fork 4.5k
Site tagline - update block description #34473
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
For some of these blocks I don't think concise is necessarily the target and it can expand a bit more. The tagline, for example, can generally be confusing, and it's fine if it takes a few more lines to explain. What is the clarity that it gives visitors, for example? It won't necessarily be shown in search results, but it might be used in social media shares, etc. |
Social media added back in!
It's a few words shorter than the previous version, but that wasn't the main point of this clean up iteration. As far as the clarity question: Site descriptions are there to describe/clarify/give clarity to your users what your site is about. Agree that it most often is seen in social channels today. |
@mtias should we merge the update description? |
db9d1d1
to
9ff7c21
Compare
There were conflicts in this PR because files changed since the PR was initially pushed. |
Do we still want to merge this one? If yes, then I think the docs should be updated to prevent the tests from failing (see failing tests in https://github.com/WordPress/gutenberg/runs/6271589009?check_suite_focus=true) 👍 |
I came across this PR while checking for PRs that haven't been reviewed in a long time. I also think this PR is still valid, but I think the conflict needs to be resolved and the documentation updated ( |
9ff7c21
to
2ad5e81
Compare
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.
To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Flaky tests detected in 2ad5e81. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/16222127644
|
Co-authored-by: kellychoffman <kellychoffman@git.wordpress.org> Co-authored-by: Mamaduka <mamaduka@git.wordpress.org> Co-authored-by: annezazu <annezazu@git.wordpress.org> Co-authored-by: mtias <matveb@git.wordpress.org> Co-authored-by: aristath <aristath@git.wordpress.org> Co-authored-by: t-hamano <wildworks@git.wordpress.org>
Part of an overall call to update block descriptions to more clear, consistent, and educational.
Before:
After:
Feedback welcome! (Copy is hard.) Props @annezazu for the collab.