[Blocks]: Fix single block selection by holding shift key
#34137
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: +2 B (0%) Total Size: 1.03 MB
ℹ️ View Unchanged
|
ellatrix
reviewed
Aug 18, 2021
| await page.keyboard.type( 'test' ); | ||
|
|
||
| await saveDraft(); | ||
| await page.reload(); |
There was a problem hiding this comment.
Why is saving and reloading needed?
There was a problem hiding this comment.
To start fresh with nothing selected. I guess I could alternatively click something outside the block editor..
ellatrix
reviewed
Aug 18, 2021
| @@ -165,7 +165,13 @@ export function useMultiSelection( clientId ) { | |||
|
|
|||
| if ( event.shiftKey ) { | |||
| const blockSelectionStart = getBlockSelectionStart(); | |||
| if ( blockSelectionStart !== clientId ) { | |||
There was a problem hiding this comment.
If you hold shift and click on the same block, isn't this condition false?
There was a problem hiding this comment.
Exactly and that's why it thinks we are in multi selection mode. getBlockSelectionStart is undefined if we haven't selected a block. So my thinking was that we should check first if a block is selected.
ellatrix
approved these changes
Aug 18, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes: #34118
If we have no block selected and select one by holding the
shiftkey, it makes the block uneditable and there is no clear way to get it back to normal state.This happened because when holding
shiftand clicking a block, we assumed there is already a block selected. Currently if you follow the testing instructions the blocks are not editable. In this PR the block is just selected.Testing instructions
shiftkey andclickto a block (for example a paragraph which has richText support).