Combine useSetting functions #31782
Closed
Combine useSetting functions #31782
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: +11 B (0%) Total Size: 1.32 MB
ℹ️ View Unchanged
|
7 tasks
youknowriad
reviewed
May 17, 2021
| @@ -62,17 +64,20 @@ const deprecatedFlags = { | |||
| * const isEnabled = useSetting( 'typography.dropCap' ); | |||
| * ``` | |||
| */ | |||
| export default function useSetting( path ) { | |||
| export default function useSetting( path, name = '', store ) { | |||
There was a problem hiding this comment.
Hi there! I think for me it doesn't make sense to pass a "store" here. (Why are we accessing the editSite store in the block-editor package, what happens if the shape of the edit-site store changes but not the block-editor) It feels like we're sharing code just for the sake of doing so. In these situations, I think it's probably better to leave the duplication in place. what may seem similar may not be in reality (edit-site allows editing these but not block-editor)
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
After the refactor in #31587 we now have 2
useSettingfunctions: one in the block-editor and a 2nd one in the site-editor.This PR combines the 2
useSettingfunctions we currently have to avoid code duplication:nameparam to the function - default touseBlockEditContext()if empty.storeparam to the function - default toblockEditorStoreif empty.storeparams to calls.We will now have a single
useSettingfunction, which can be imported from@wordpress/block-editor.How has this been tested?
Tested the site-editor and block-editor, both seem to be working fine.
Checklist:
*.native.jsfiles for terms that need renaming or removal).