Fix separator styles #30255
Merged
Fix separator styles #30255
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
youknowriad
commented
Mar 25, 2021
14 tasks
|
Size Change: +26 B (0%) Total Size: 1.42 MB
ℹ️ View Unchanged
|
scruffian
reviewed
Mar 25, 2021
| @@ -7,7 +7,7 @@ | |||
|
|
|||
| // Default, thin style | |||
| &:not(.is-style-wide):not(.is-style-dots) { | |||
| max-width: 100px; | |||
| width: 100px; | |||
There was a problem hiding this comment.
I really don't love this line. It makes wide and full alignments on this block meaningless. Not sure if we could remove it though.
There was a problem hiding this comment.
that's an opinionated style, basically the default separator is just a small one. This PR just fixes the separator behavior that broke recently.
There was a problem hiding this comment.
right, I just think this style is a really bad one because its so hard to work around. TT1 Blocks opts into opinionated styles, and uses separators in the header and footer - even though they are set to align wide, the separator is forced to 100px, which isn't what the design wants. We could override it with specific widths for alignwide and alignfull but that feels unsatisfactory when we have alignment styles in Gutenberg.
There was a problem hiding this comment.
I suggest you open a dedicated issue and discuss with other designers. For now, I'd like to focus on making the editor and frontend match.
There was a problem hiding this comment.
I would echo Riad, I think there's a great opportunity to vastly improve our opinionated styles, to make them fantastic and if necessary, even more opinionated.
jasmussen
approved these changes
Mar 26, 2021
There was a problem hiding this comment.
Before:
After:
Note that the Empty Theme opts into theme.scss styles, which make the separator light gray. But it also uses a 2px bottom border, rather than 1px above and 1px below, observe the competing styles:
It seems like we could remove the duplicate styles from the theme.scss file, since there's now a 2px style for the default separator.
That's a small thing though, up to you.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related #29976
Just make the separator styles match between the editor and the frontend.