Mobile Release v1.48.1 #29680
Closed
Mobile Release v1.48.1 #29680
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Ignore empty width attribute in columns
The editor was crashing when attempting to render a column block which contained an empty width attribute (i.e `<!-- wp:column {"width":""} -->`.
The exception occurred when accessing a property of an undefined object, so adding a default object (`|| {}`) fixes this by allowing the property to be accessed.
* Update react-native-editor changelog
* Add missing dependency to useSelect in columns block
Co-authored-by: Carlos Garcia <fluiddot@gmail.com>
* Release script: Update react-native-editor version to 1.46.1 * Release script: Update with changes from 'npm run core preios' * Update react-native-editor CHANGELOG * [RNMobile] Add capability to bridge to show/hide audio block (#28952) * [RNMobile] Ignore column width attribute when empty (#29015) * Update react-native-editor CHANGELOG * Fixes minor changelog alignement issue * Add Stories bridge methods for iOS (#29083) Add missing bridge methods for the Stories block. The absence of these threw an error, even though Stories block isn't fully supported for iOS just yet. Co-authored-by: Ceyhun Ozugur <ceyhunozugur@gmail.com> Co-authored-by: Paul Von Schrottky <paul.von.schrottky@automattic.com> Co-authored-by: Antonis Lilis <antonis.lilis@automattic.com> Co-authored-by: David Calhoun <dpcalhoun@gmail.com>
* Wip: Mobile RichText - Updating old value after splitting * Mobile - Fix splitting/merging issues and keyboard jumpiness on Android * Mobile - RichText - Add isIOS check for componentDidUpdate and use blockEditorStore * Mobile - RichText - Prevent onTextUpdate on Android
This reverts commit 4b9d13f.
3 tasks
|
Size Change: -70 B (0%) Total Size: 1.4 MB
ℹ️ View Unchanged
|
jd-alexander
approved these changes
Mar 11, 2021
There was a problem hiding this comment.
@fluiddot just double-checking if we will be including the story-related changes here.
Good question! I see that the |
# Conflicts: # packages/react-native-aztec/package.json # packages/react-native-bridge/package.json # packages/react-native-editor/CHANGELOG.md # packages/react-native-editor/ios/Podfile.lock # packages/react-native-editor/package.json
jd-alexander
approved these changes
Mar 11, 2021
There was a problem hiding this comment.
Changes here look good @fluiddot
- The splitting/merging functionality is reverted in our mobile release until the fix is completed.
- The iOS Story bridge behavior is included to resolve the Story issues.
- The page fetching logic that resolves the reusable block crash is operating as expected.
LGTM. Awaiting CI to pass to verify all is well.
The CI looks totally frozen so I don't think it's going to run 😞 . We could either:
|
Indeed. We could push an empty commit and see if that works. |
|
Nope, I pushed an empty commit but didn't work 😞 . I think this is most likely caused by having conflict files 🤷♂️ , I'm going to create a new branch for fixing the conflicts and there we'll see if the test pass. |
You are right. I remember seeing this behavior with previous conflicts 👍🏾 |
|
Let's see if they pass in this PR. I had to update that branch with |
Understood. So to ensure I understand clearly if that PR passes what will be done next? Also, will we be bypassing the failing PHP tests somehow? or are we waiting until they are resolved? |
If the PR passes, we can consider the release ready and start merging the PRs, the first part would be to merge the Gutenberg-mobile PR to trunk, update the Gutenberg reference in the integration branches on
That's a good question, I don't think we can do much thing there apart from wait for a fix. |
Indeed! Thanks for doing the GB reference update in the integration branches. Monitoring the builds.
True. |
7 tasks
075faab to
1c823f6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR can't be merged into
trunkbecause include changes that could break the web version, specifically the changes from this commit.Similar to what was done in
1.48.0release, we should have a different branch without those changes for merging the release intotrunk.Description
Release 1.48.1 of the react-native-editor and Gutenberg-Mobile.
For more information about this release and testing instructions, please see the related Gutenberg-Mobile PR: wordpress-mobile/gutenberg-mobile#3237
Checklist: