Components: Add TooltipButton #29523
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: +6.73 kB (0%) Total Size: 1.4 MB
ℹ️ View Unchanged
|
ItsJonQ
approved these changes
Mar 3, 2021
There was a problem hiding this comment.
🚀 from me! Thank you @sarayourfriend .
Excited to see how this consolidates in the adapted Button :)
|
Thanks for updating the tests @sarayourfriend ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds a simple TooltipButton component which composes Tooltip and Button together. This is necessary as an adaptive layer between the old and new Buttons becuase the old Button supported this tooltip functionality.
It also adds the
describedByfunctionality toButtonallowing it to mirror the old button's accessibility behavior.TODO:
How has this been tested?
Unit tests and storybook
Types of changes
New feature
Checklist: