Navigation block: Allow very thin menus. #29555
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: +27 B (0%) Total Size: 1.39 MB
ℹ️ View Unchanged
|
aristath
approved these changes
Mar 4, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
There exists a
min-height: 44px;rule for the navigation block. This is meant for the placeholder, but also applies for the menu itself.This PR moves it to only apply to the placeholder, or when selected (so there's space for the appender), and it aligns a spinner icon better.
How has this been tested?
Insert a navigation menu, observe the spinner looks good when you press "Add all pages". Here's before:
If you can find a theme with a very thin menu, it will be allowed to be less than 44px tall. Otherwise just inspect the navigation block and note there isn't a min-height.
Checklist: