[RNMobile] Change mediaFiles from string to a dictionary #28766
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: 0 B Total Size: 1.37 MB ℹ️ View Unchanged
|
This was referenced Feb 5, 2021
Merged
|
@guarani - could you take a look please? 🙏 |
|
@guarani I just added you to https://bjttestsite12.wordpress.com in order to test this. There's only one post there which includes a story. You should just be able to open it in the app and try to edit that post. The story editor hasn't been merged in to |
# Conflicts: # packages/react-native-bridge/ios/GutenbergBridgeDelegate.swift
|
Checking the "code tested" checkbox although there are no unit tests for this. The bridge delegates are manually verified as a part of the release process for Mobile Gutenberg. |
|
Congratulations on your first merged pull request, @bjtitus! We'd like to credit you for your contribution in the post announcing the next WordPress release, but we can't find a WordPress.org profile associated with your GitHub account. When you have a moment, visit the following URL and click "link your GitHub account" under "GitHub Username" to link your accounts: https://profiles.wordpress.org/me/profile/edit/ And if you don't have a WordPress.org account, you can create one on this page: https://login.wordpress.org/register Kudos! |
fluiddot
pushed a commit
that referenced
this pull request
Feb 18, 2021
fluiddot
added a commit
that referenced
this pull request
Feb 18, 2021
* Release script: Update react-native-editor version to 1.46.1 * Release script: Update with changes from 'npm run core preios' * Update react-native-editor CHANGELOG * [RNMobile] Add capability to bridge to show/hide audio block (#28952) * [RNMobile] Ignore column width attribute when empty (#29015) * Release script: Update react-native-editor version to 1.46.2 * Release script: Update with changes from 'npm run core preios' * Enable mediaFilesBlockReplaceSync RN bridge function only on Android * Add missing arguments in RN bridge function on iOS * Change mediaFiles from string to a dictionary (#28766) Co-authored-by: Ceyhun Ozugur <ceyhunozugur@gmail.com> Co-authored-by: Paul Von Schrottky <paul.von.schrottky@automattic.com> Co-authored-by: Brandon Titus <b@titus.io>
dcalhoun
pushed a commit
that referenced
this pull request
Feb 18, 2021
fluiddot
added a commit
that referenced
this pull request
Feb 19, 2021
* Release script: Update react-native-editor version to 1.46.1 * Release script: Update with changes from 'npm run core preios' * Update react-native-editor CHANGELOG * [RNMobile] Add capability to bridge to show/hide audio block (#28952) * [RNMobile] Ignore column width attribute when empty (#29015) * Release script: Update react-native-editor version to 1.46.2 * Release script: Update with changes from 'npm run core preios' * Enable mediaFilesBlockReplaceSync RN bridge function only on Android * Add missing arguments in RN bridge function on iOS * Change mediaFiles from string to a dictionary (#28766) Co-authored-by: Ceyhun Ozugur <ceyhunozugur@gmail.com> Co-authored-by: Paul Von Schrottky <paul.von.schrottky@automattic.com> Co-authored-by: Brandon Titus <b@titus.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes an incorrect type in the
GutenbergBridgeDelegatemethods for the "media files" block (a.k.a. Stories).See wordpress-mobile/WordPress-iOS#15811
See wordpress-mobile/gutenberg-mobile#3113
How has this been tested?
I could not find a good place to add a unit test. Please let me know if there's a good way to programmatically test!
Types of changes
This is a bug fix for delegate methods related to the "media files" Gutenberg block.
Checklist: