-
Notifications
You must be signed in to change notification settings - Fork 4.5k
Stabilize adding blocks end to end test #27493
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…d otherwise wait for patterns to load
Size Change: 0 B Total Size: 1.19 MB ℹ️ View Unchanged
|
Agree. Perhaps a placeholder with fixed height when loading the patterns would help? Not familiar with that piece of code though. |
That's what I was thinking too. I've made an issue—#27494. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is good enough and does the job. We can come back to it after refactoring the way patterns load. 👍
Thanks! |
Description
The
adding blocks
test has been failing recently at the testit inserts blocks at root level when using the root appender while selection is in an inner block
.The image snapshot for this failure shows that the test makes it almost all the way to the end but fails to add a paragraph block from the quick inserter menu:

When manually testing it's noticable that the patterns in the menu have a slight delay in loading their content causing a shift in the layout in the inserter. I think what's happening is that the layout shift is causing the test to fail to click on the block. When the popover is above the button this is particularly difficult, because everything above the patterns shift up and down.
This PR should fix by doing the following:
waitForInserterPatternLoad
helper function that waits for all the patterns to have a height greater than zero. I couldn't think of a better option here, I think the best idea would be to look at improving the way patterns loadTypes of changes
Bug fix (non-breaking change which fixes an issue)
Checklist: