Query block: Fix dirtying post on load #27323
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: +7 B (0%) Total Size: 1.19 MB
ℹ️ View Unchanged
|
gziolo
reviewed
Nov 27, 2020
| @@ -129,8 +129,12 @@ export default function QueryInspectorControls( { | |||
|
|
|||
| const [ querySearch, setQuerySearch ] = useState( query.search ); | |||
| const onChangeDebounced = useCallback( | |||
| debounce( () => setQuery( { search: querySearch } ), 250 ), | |||
| [ querySearch ] | |||
| debounce( () => { | |||
There was a problem hiding this comment.
debounce makes me always think that there is an underlying problem that can't be easily solved and it makes the issue invisible. Do you know why is it called in useEffect in the first place?
There was a problem hiding this comment.
Does it exist here to prevent too many requests to the server when typing?
There was a problem hiding this comment.
Does it exist here to prevent too many requests to the server when typing?
Yes.
gziolo
approved these changes
Nov 27, 2020
There was a problem hiding this comment.
Let's get this in, it makes sense to include this check.
I'm wondering if in the future the local state could be removed completely in this component in favor of setQuery call. It would require updating the part that triggers network requests to use debouncing instead, but it would benefit the case when changing other properties quickly as well.
6f36148 to
106ccdb
Compare
106ccdb to
143aea1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes: #26838
There was a bug that when loading a post with a
Queryblock would trigger an initial update to its attributes without needing it. This PR fixes it.