Size Change: +46 B (0%)

Total Size: 1.21 MB

_{compressed-size-action}

Confirmed, this fixes the issue:

However, my golly that dropdown needs a lot of love. Why is the text gray? Why is it allcaps? (I know @aaronrobertshaw is struggling with this exact issue in #26444)

Why is the popover borderless when not in focus?

To be quite clear, none of this is your doing, and I really appreciate your taking a stab at improving this menu, it's clearly full of low hanging fruit. Here's the CSS as best I can tell:

It seems to me the problem here is that panel titles are lumped in with the custom select control, when those should be separate. So I'd extract .components-custom-select-control__menu li and give it its own separate definition. Want to take a stab at that?

At some point the package-lock.json file was included, it shouldn't be. I can't recall exactly how to remove a changed file commit from a PR, but we need to remove that and then this one is good to ship.

@jasmussen Ah goodness that was the last commit, I'll work out a way to solve that and get it ready. Thanks.

@tellthemachines if this could get a final code review I think it might be able to slip in the group for the release. It's low priority so no stress if not, but as a block already released would fix a bug. I would love to know if I've done the removal of the file correctly and if not learn how to do that though.

@karmatosed the Navigation Block isn't in Core yet, so this doesn't need to go into 5.6, but happy to help out with it anyway!

The package-lock.json shouldn't be deleted, just removed from the changeset because we're not interested in making any changes to it in this branch. You can do that locally in terminal with git checkout master package-lock.json (you have to be in the branch you made these changes in) and commit the result. That should get rid of the merge conflict too 😅

Thanks so much @tellthemachines, I've done that 🙏🏻 This still needs a code review, but should be ready for that now.

Awesome, thanks. Let's get this PR in then and work can continue.

Why was package-lock.json updated? Tests are failing now in master.

@ellatrix regarding this comment:

The package-lock.json shouldn't be deleted, just removed from the changeset because we're not interested in making any changes to it in this branch. You can do that locally in terminal with git checkout master package-lock.json (you have to be in the branch you made these changes in) and commit the result. That should get rid of the merge conflict too

Happy to revert this merge if issue is problem though.

Right, it should have been removed from the branch and synced with master?

And no worries, it's easy enough to fix. It's been partially reverted to make the tests happy. Not sure if the rest should be reverted, but it's not causing any failures.