Size Change: +106 B (0%)

Total Size: 1.19 MB

_{compressed-size-action}

This is a very cool PR! Thank you for creating the various videos! They show a nice overview of the creativity that one can add by repeating a pattern. I have also tested the PR.

One thing that comes to mind is how the Customizer handles the Background Image.
It uses a Preset drop down.

Here is an example of adding the same drop down to Gutenberg Cover block.

I will ping:
@mapk @ItsJonQ
As we need some more input on the UI.

I do like @paaljoachim's comment about including a few more options as the Customizer does...

Yes. I do like it too, but wondering whether it should be adapted to the final user. I mean maybe it isn't totally clear what means every background option.

..., but I don't want to hold up this PR.

👍

Maybe we can get this in and then work toward those other options in another PR?

Sounds good to me. Thanks.

@retrofox I think this may have broken unit tests for the repo -- I think isRepeated needs to be added to the block fixtures for the unit tests

Fix in #26044, I think

@retrofox I think this may have broken unit tests for the repo -- I think isRepeated needs to be added to the block fixtures for the unit tests

Sorry, my bad. I didn't realize it. 🤦 Thank you very much for fixing it. It won't happen again.

Awesome feature btw! :)