Skip to content

WIP: Navigation Link variations #24613

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

WIP: Navigation Link variations #24613

wants to merge 1 commit into from

Conversation

noisysocks
Copy link
Member

@noisysocks noisysocks commented Aug 18, 2020 •
edited
Loading

This started as an exploration of #22919 but ended up encompassing a few different semi-related things:

@noisysocks noisysocks added the [Block] Navigation Affects the Navigation Block label Aug 18, 2020
@github-actions
Copy link

github-actions bot commented Aug 18, 2020 •
edited
Loading

Size Change: +608 B (0%)

Total Size: 1.16 MB

Filename Size Change
build/block-directory/index.js 7.97 kB +2 B (0%)
build/block-editor/index.js 126 kB +88 B (0%)
build/block-library/editor-rtl.css 8.37 kB +10 B (0%)
build/block-library/editor.css 8.37 kB +9 B (0%)
build/block-library/index.js 133 kB +405 B (0%)
build/block-serialization-default-parser/index.js 1.88 kB +1 B
build/blocks/index.js 47.6 kB -1 B
build/components/index.js 200 kB +1 B
build/compose/index.js 9.67 kB -3 B (0%)
build/core-data/index.js 11.8 kB +1 B
build/data/index.js 8.55 kB -2 B (0%)
build/edit-navigation/index.js 11 kB +42 B (0%)
build/edit-post/index.js 304 kB +2 B (0%)
build/edit-widgets/index.js 11.7 kB -1 B
build/editor/index.js 45.4 kB +57 B (0%)
build/element/index.js 4.65 kB -2 B (0%)
build/keyboard-shortcuts/index.js 2.52 kB +1 B
build/list-reusable-blocks/index.js 3.11 kB -1 B
build/media-utils/index.js 5.33 kB -1 B
build/rich-text/index.js 13.9 kB -1 B
build/server-side-render/index.js 2.77 kB +1 B
ℹ️ View Unchanged
Filename Size Change
build/a11y/index.js 1.14 kB 0 B
build/annotations/index.js 3.67 kB 0 B
build/api-fetch/index.js 3.44 kB 0 B
build/autop/index.js 2.82 kB 0 B
build/blob/index.js 620 B 0 B
build/block-directory/style-rtl.css 953 B 0 B
build/block-directory/style.css 952 B 0 B
build/block-editor/style-rtl.css 10.7 kB 0 B
build/block-editor/style.css 10.7 kB 0 B
build/block-library/style-rtl.css 7.45 kB 0 B
build/block-library/style.css 7.45 kB 0 B
build/block-library/theme-rtl.css 729 B 0 B
build/block-library/theme.css 730 B 0 B
build/block-serialization-spec-parser/index.js 3.1 kB 0 B
build/components/style-rtl.css 15.7 kB 0 B
build/components/style.css 15.7 kB 0 B
build/data-controls/index.js 1.29 kB 0 B
build/date/index.js 5.38 kB 0 B
build/deprecated/index.js 772 B 0 B
build/dom-ready/index.js 568 B 0 B
build/dom/index.js 4.47 kB 0 B
build/edit-navigation/style-rtl.css 1.12 kB 0 B
build/edit-navigation/style.css 1.12 kB 0 B
build/edit-post/style-rtl.css 5.61 kB 0 B
build/edit-post/style.css 5.61 kB 0 B
build/edit-site/index.js 17 kB 0 B
build/edit-site/style-rtl.css 3.06 kB 0 B
build/edit-site/style.css 3.06 kB 0 B
build/edit-widgets/style-rtl.css 2.45 kB 0 B
build/edit-widgets/style.css 2.45 kB 0 B
build/editor/editor-styles-rtl.css 537 B 0 B
build/editor/editor-styles.css 539 B 0 B
build/editor/style-rtl.css 3.8 kB 0 B
build/editor/style.css 3.79 kB 0 B
build/escape-html/index.js 733 B 0 B
build/format-library/index.js 7.71 kB 0 B
build/format-library/style-rtl.css 547 B 0 B
build/format-library/style.css 548 B 0 B
build/hooks/index.js 2.13 kB 0 B
build/html-entities/index.js 621 B 0 B
build/i18n/index.js 3.56 kB 0 B
build/is-shallow-equal/index.js 711 B 0 B
build/keycodes/index.js 1.94 kB 0 B
build/list-reusable-blocks/style-rtl.css 476 B 0 B
build/list-reusable-blocks/style.css 476 B 0 B
build/notices/index.js 1.79 kB 0 B
build/nux/index.js 3.4 kB 0 B
build/nux/style-rtl.css 671 B 0 B
build/nux/style.css 668 B 0 B
build/plugins/index.js 2.56 kB 0 B
build/primitives/index.js 1.41 kB 0 B
build/priority-queue/index.js 789 B 0 B
build/redux-routine/index.js 2.85 kB 0 B
build/shortcode/index.js 1.7 kB 0 B
build/token-list/index.js 1.27 kB 0 B
build/url/index.js 4.06 kB 0 B
build/viewport/index.js 1.85 kB 0 B
build/warning/index.js 1.14 kB 0 B
build/wordcount/index.js 1.17 kB 0 B

compressed-size-action

@noisysocks noisysocks force-pushed the try/dynamic-navigation-link-urls branch from a057ca4 to dbe0aae Compare August 19, 2020 06:40
@noisysocks noisysocks changed the title WIP: Dynamic Navigation Link URLs WIP: Navigation Link variations Aug 19, 2020
@noisysocks noisysocks force-pushed the try/dynamic-navigation-link-urls branch from dbe0aae to b271299 Compare August 19, 2020 06:42
@noisysocks noisysocks force-pushed the try/dynamic-navigation-link-urls branch from b271299 to daac2ce Compare August 20, 2020 02:05
@noisysocks noisysocks changed the base branch from master to add/formats-categories-suggestions August 20, 2020 02:06
@noisysocks
Copy link
Member Author

I think we'll ultimately want all of the changes here but better to introduce them in smaller more focused PRs.

@noisysocks noisysocks closed this Aug 20, 2020
@noisysocks noisysocks deleted the try/dynamic-navigation-link-urls branch August 20, 2020 02:36
@noisysocks noisysocks mentioned this pull request Aug 20, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
[Block] Navigation Affects the Navigation Block
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Navigation: Split Link block into Post, Page, Category, Link, etc.
1 participant
@noisysocks