Size Change: +180 B (0%)

Total Size: 1.14 MB

_{compressed-size-action}

Took this for a spin and have a few comments:

• With the URL here, I wonder if we can remove the link icon altogether like I did above? We'd still need it to show where the block doesn't have a URL, but otherwise I don't think its doing much other than taking up space.
• Can we remove the siteurl when linking to a post/page on the current site?
• For longer URL's I imagine we'll need to truncate, similar to how the link UI truncates the URL.
• This brings up a lot of questions around the connection between this button in the toolbar, and the Link UI. Part of me wonders if I should be able to edit the URL directly within the Toolbar and not need to open the Link UI.

@shaunandrews do you think maybe removing the icon makes the link too much a label, enough for the user to ignore it when they want to change the link?

@shaunandrews I updated this PR to reflect your suggestions. I wasn't entirely sure about the icon part so at the moment it's in a sort of intermediary state where the icon is there for new links:

But as soon as you assign a URL, it's replaced by that URL:

What do you think would be a proper way to address it?

This brings up a lot of questions around the connection between this button in the toolbar, and the Link UI. Part of me wonders if I should be able to edit the URL directly within the Toolbar and not need to open the Link UI.

I'm totally up for exploring that - a mockup would be more than enough to get me started. It seems like figuring out the icon would be the key here - clicking on an icon just to have it replaced by an input would be weird.

A lot more work is required, but an initial attempt is functional:

Taking a closer look at the design for this over in #23375.

I took the latest design from #23375 and got an early prototype of interactions working:

There are still some visual glitches and keyboard navigation needs a closer look, but I'd like to get some early broad strokes feedback on the direction @shaunandrews @noisysocks @talldan @draganescu.

I will put this PR on hold for now - the design discussion is still going