Block Editor: Update BEM syntax to CSS modifer guidelines #19738
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously: #17846 (comment), #16790 (comment)
This pull request seeks to update incorrect usage of BEM modifier syntax to use the
is-
-based modifier syntax as recommended in the CSS naming guidelines.This impacts two components:
LinkControl
ResponveBlockControl
In the latter case, the implementation has been revised as mentioned at #16790 (comment) to unify the application of a single
is-responsive
modifier class.Open Question: There was a
hidden
attribute included previously inResponsiveBlockControl
which would never be applied given how the logic flowed. The changes here seek only to preserve the current behavior. If it needs to be applied, I can restore it as appropriate.Testing Instructions:
Repeat testing instructions from #17846 and #16790, verifying that there are no regressions.
Ensure tests pass: