Skip to content

Conversation

anischarolia-multidots
Copy link

@anischarolia-multidots anischarolia-multidots commented Aug 23, 2019

Fixes #17681.

Files modified:

  • packages/block-library/src/latest-posts/edit.js
  • packages/block-library/src/latest-posts/index.php
  • packages/block-library/src/latest-posts/style.scss

Description

A toggle button to display the name of post's author has been added in 'Latest posts' blog.

How has this been tested?

Tested locally and it works as expected.

Screenshots

added-display-author-name-button

Types of changes

New feature in 'Latest posts' blog to display Author name of post.

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • My code has proper inline documentation.
  • I've included developer documentation if appropriate.

Files modified:
- packages/block-library/src/latest-posts/edit.js
- packages/block-library/src/latest-posts/index.php
- packages/block-library/src/latest-posts/style.scss
@gziolo gziolo added First-time Contributor Pull request opened by a first-time contributor to Gutenberg repository [Block] Latest Posts Affects the Latest Posts Block [Type] Enhancement A suggestion for improvement. labels Aug 27, 2019
@jorgefilipecosta jorgefilipecosta added the Needs Design Feedback Needs general design feedback. label Nov 14, 2019
@draganescu
Copy link
Contributor

Howdy @anischarolia-multidots I tested this PR and it works very well. I had to rebase locally to make it work. Could you please refresh this PR so it has no more conflicts? That would be great :)

Here is the diff with the current master. You can apply this to the current master and then force push this branch.

Copy link
Member

@karmatosed karmatosed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From a design perspective approving. In the future, I would love to avoid having multiple toggles. However, that feels outside of this issue as toggles are being used for other elements here. With that in mind, let's approve this for now and look for some iterations. Thanks.

@MichaelArestad MichaelArestad removed the Needs Design Feedback Needs general design feedback. label May 26, 2020
@paaljoachim
Copy link
Contributor

paaljoachim commented May 26, 2020

I do believe this PR can be closed as a new PR #20595 has been opened to take its place.
If I am wrong then of course open the PR again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Latest Posts Affects the Latest Posts Block First-time Contributor Pull request opened by a first-time contributor to Gutenberg repository [Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Latest Posts Block: Option to show/hide the post author
7 participants