Skip to content

Update Button block wording #13933

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Feb 19, 2019
Merged

Update Button block wording #13933

merged 3 commits into from
Feb 19, 2019

Conversation

samikeijonen
Copy link
Contributor

@samikeijonen samikeijonen commented Feb 18, 2019 •
edited by gziolo
Loading

Description

  • Update button block description to mention it's a link.
  • Add keyword link.

Closes #13923.

How has this been tested?

Tested on local, I see the wording change. And I can also search using keyword link.

Screenshots

Button description:
Button block description

Search by keyword link:
Search modal with keyword link

Types of changes

  • Button block description wording.
  • Add keyword.

Checklist:

  • [ x] My code is tested.
  • [x ] My code follows the WordPress code style.
  • [ x] My code follows the accessibility standards.
  • My code has proper inline documentation.
  • I've included developer documentation if appropriate.

@samikeijonen samikeijonen mentioned this pull request Feb 18, 2019
Closed
@talldan talldan added [Type] Task Issues or PRs that have been broken down into an individual action to take Needs Copy Review Needs review of user-facing copy (language, phrasing) [Block] Buttons Affects the Buttons Block labels Feb 19, 2019
@gziolo gziolo added this to the 5.2 (Gutenberg) milestone Feb 19, 2019
gziolo
gziolo approved these changes Feb 19, 2019
View reviewed changes
Copy link
Member

@gziolo gziolo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code wise, it looks good. I would prefer to wait until someone will confirm that it is indeed the change for the description that it's expected before we proceed with merge.

@michelleweber
Copy link

A separate small thing that needs updated -- it should be "button-style." Without the dash it's a confusing phrase, and "button-style" is a bit clearer than "styled" (even though "styled" is entirely accurate).

@gziolo
Copy link
Member

gziolo commented Feb 19, 2019

"button-style" it is 👍

@gziolo gziolo merged commit ad9bbe5 into WordPress:master Feb 19, 2019
@gziolo
Copy link
Member

gziolo commented Feb 19, 2019

@samikeijonen thanks for your another contribution 🎉

@gziolo gziolo changed the title Update button wording Update Button block wording Feb 19, 2019
@samikeijonen
Copy link
Contributor Author

Thanks @michelleweber and @gziolo!

@samikeijonen samikeijonen deleted the update/button-wording branch February 19, 2019 13:41
@ellatrix ellatrix mentioned this pull request Mar 4, 2019
Merged
youknowriad pushed a commit that referenced this pull request Mar 6, 2019
@samikeijonen @youknowriad
Update button wording (#13933)
c89dd0c 
* Update button block description by using wording about link.

* Add keyword: link.

* Update index.js
youknowriad pushed a commit that referenced this pull request Mar 6, 2019
@samikeijonen @youknowriad
Update button wording (#13933)
fca9d56 
* Update button block description by using wording about link.

* Add keyword: link.

* Update index.js
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gziolo gziolo gziolo approved these changes

@ajitbohra ajitbohra Awaiting requested review from ajitbohra

@jorgefilipecosta jorgefilipecosta Awaiting requested review from jorgefilipecosta

@noisysocks noisysocks Awaiting requested review from noisysocks

@notnownikki notnownikki Awaiting requested review from notnownikki

@Soean Soean Awaiting requested review from Soean

@talldan talldan Awaiting requested review from talldan

@youknowriad youknowriad Awaiting requested review from youknowriad

Assignees
No one assigned
Labels
[Block] Buttons Affects the Buttons Block Needs Copy Review Needs review of user-facing copy (language, phrasing) [Type] Task Issues or PRs that have been broken down into an individual action to take
Projects
None yet
Milestone
5.2 (Gutenberg)
Development

Successfully merging this pull request may close these issues.
4 participants
@samikeijonen @michelleweber @gziolo @talldan